Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for znver1 and znver1_32 architectures #889

Conversation

Conan-Kudo
Copy link
Member

@Conan-Kudo Conan-Kudo commented Feb 2, 2020

OpenMandriva offers a Ryzen-optimized variant of the distribution, so libdnf needs to understand this architecture on OpenMandriva.

Depends on the following PRs:

OpenMandriva offers a Ryzen-optimized variant of the distribution,
so libdnf needs to understand this architecture on OpenMandriva.
@m-blaha
Copy link
Member

m-blaha commented Feb 6, 2020

Looks like modularity on ryzen machine (I do not have such a hardware, I just tweaked is_ryzen() to return always true) started to misbehave:

$ dnf module list
Modular dependency problems:

 Problem 1: nothing provides requested module(stratis:1:3020190306064421)
 Problem 2: nothing provides requested module(standard-test-roles:3.0:3020190319161255)
 Problem 3: nothing provides requested module(scala:2.10:20180702155503)
 Problem 4: nothing provides requested module(rpick:latest:3020190313083345)
.
.
.

@j-mracek isn't it possible that modularity uses arch (which is now znver1on ryzen) instead of base_arch to compute dependencies?

@m-blaha m-blaha added the blocked label Feb 6, 2020
@j-mracek
Copy link
Contributor

j-mracek commented Feb 6, 2020

I have a bad news. DNF/LIBDNF uses arch (not basearch) for creation for the sack and modular sack. Therefore the change in detection requires change in dnf (dnf.rpm._BASEARCH_MAP), rpm and libsolv. DNF uses basearch only for downloading of repositories and for comps.

@m-blaha
Copy link
Member

m-blaha commented Feb 6, 2020

True:

# dnf install acpi
Error: 
 Problem: conflicting requests
  - package acpi-1.7-11.fc30.x86_64 does not have a compatible architecture

@Conan-Kudo
Copy link
Member Author

@m-blaha @j-mracek Wait, shouldn't this work once the rpm PR lands? We make znver1 descend from x86_64, so it's considered a superset and x86_64 packages are compatible...

@j-mracek
Copy link
Contributor

j-mracek commented Feb 6, 2020

It means that the PR must require future rpm and libsolv with required change. Therefore we have to wait till rpm and libsolv accept the change and release it. Libsolv will wait till rpm accept it.

@dmach dmach changed the base branch from master to dnf-4-master March 5, 2020 12:18
@m-blaha m-blaha closed this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants