Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ROS 2 Humble #162

Merged
merged 19 commits into from
Nov 22, 2022
Merged

Support ROS 2 Humble #162

merged 19 commits into from
Nov 22, 2022

Conversation

Kuwamai
Copy link
Contributor

@Kuwamai Kuwamai commented Oct 31, 2022

What does this implement/fix?

ROS 2 Humbleに対応します。

Does this close any currently open issues?

しません

How has this been tested?

Gazeboと実機で、crane_x7_examplesのサンプルが動作することを確認しています。

Any other comments?

Checklists

@Kuwamai Kuwamai added the Type: Feature New Feature label Oct 31, 2022
@Kuwamai Kuwamai self-assigned this Oct 31, 2022
@Kuwamai Kuwamai marked this pull request as ready for review November 2, 2022 06:41
@Kuwamai Kuwamai requested a review from ShotaAk November 2, 2022 06:41
@Kuwamai Kuwamai marked this pull request as draft November 16, 2022 06:47
@Kuwamai Kuwamai marked this pull request as ready for review November 17, 2022 05:25
@ShotaAk
Copy link
Contributor

ShotaAk commented Nov 21, 2022

実機実行時に下記のエラーが発生するので、moveitのjoint_limits.yamlにmax velocityをセットしてください

[move_group-1] [ERROR] [1669004207.824471669] [moveit_ros.robot_model_loader]: Specified a velocity limit for joint: crane_x7_shoulder_fixed_part_pan_joint but did not set a max velocity
[move_group-1] [ERROR] [1669004207.825310432] [moveit_ros.robot_model_loader]: Specified a velocity limit for joint: crane_x7_shoulder_revolute_part_tilt_joint but did not set a max velocity
[move_group-1] [ERROR] [1669004207.825357529] [moveit_ros.robot_model_loader]: Specified a velocity limit for joint: crane_x7_upper_arm_revolute_part_twist_joint but did not set a max velocity
[move_group-1] [ERROR] [1669004207.825459619] [moveit_ros.robot_model_loader]: Specified a velocity limit for joint: crane_x7_upper_arm_revolute_part_rotate_joint but did not set a max velocity
[move_group-1] [ERROR] [1669004207.825491321] [moveit_ros.robot_model_loader]: Specified a velocity limit for joint: crane_x7_lower_arm_fixed_part_joint but did not set a max velocity
[move_group-1] [ERROR] [1669004207.825529978] [moveit_ros.robot_model_loader]: Specified a velocity limit for joint: crane_x7_lower_arm_revolute_part_joint but did not set a max velocity
[move_group-1] [ERROR] [1669004207.825559398] [moveit_ros.robot_model_loader]: Specified a velocity limit for joint: crane_x7_wrist_joint but did not set a max velocity
[move_group-1] [ERROR] [1669004207.825589886] [moveit_ros.robot_model_loader]: Specified a velocity limit for joint: crane_x7_gripper_finger_a_joint but did not set a max velocity
[move_group-1] [ERROR] [1669004207.825619185] [moveit_ros.robot_model_loader]: Specified a velocity limit for joint: crane_x7_gripper_finger_b_joint but did not set a max velocity

Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実機での動作確認完了しました。
コメントの確認お願いします。

gazeboでの動作は未確認です(RVizから動かせなかったので調査中)

README.en.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
crane_x7_gazebo/launch/crane_x7_with_table.launch.py Outdated Show resolved Hide resolved
Kuwamai and others added 5 commits November 21, 2022 13:44
@Kuwamai Kuwamai requested a review from ShotaAk November 21, 2022 06:48
Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです

後ほど、package.xmlのバージョン更新PRを作成お願いします。

@ShotaAk ShotaAk merged commit 59c973b into ros2 Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants