Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rbs-inline and rewrite bitmap.rb #490

Merged

Conversation

Little-Rubyist
Copy link
Contributor

I'll be installing rbs-inline, which we discussed previously.
rbs-inline requires writing the type information to .rb files and generating .rbs files with rbs-inline --output.
ref: https://github.com/soutaro/rbs-inline?tab=readme-ov-file#usage

I were also considering installing rubocop-on-rbs, but decided to pass on it because rubocop has not use yet.

@yui-knk
Copy link
Collaborator

yui-knk commented Dec 27, 2024

Just in case, I want to confirm the development process.
Will we generate rbs file by rbs-inline --output on local and commit generated files so that released gem will include rbs files same as before?

@Little-Rubyist
Copy link
Contributor Author

Just in case, I want to confirm the development process. Will we generate rbs file by rbs-inline --output on local and commit generated files so that released gem will include rbs files same as before?

@yui-knk
Yes, that's correct.
If we forget to generate, we should be able to notice because the steep check will fail.

@yui-knk
Copy link
Collaborator

yui-knk commented Dec 27, 2024

I got it, thank you!

@yui-knk yui-knk merged commit ecd4f0c into ruby:master Dec 27, 2024
19 checks passed
@Little-Rubyist Little-Rubyist deleted the feature/add_rbs_inline_and_refactor_bitmap branch December 27, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants