Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use normal method definition instead of attr_reader in RBI files #2719

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Apr 19, 2024

Tapioca currently rewrites attr_reader methods in RBI files to normal method definitions when merging signatures, but doesn't include the annotations in the merged result.

Related issue: Shopify/tapioca#1709

This means that current methods typed with attr_reader in RBI files are actually untyped in the merged RBI files. So this commit declares those methods with normal method definitions in the RBI files to work around this issue.

Tapioca currently rewrites `attr_reader` methods in RBI files to normal
method definitions when merging signatures, but doesn't include the annotations
in the merged result.

Related issue: Shopify/tapioca#1709

This means that current methods typed with `attr_reader` in RBI files are
actually untyped in the merged RBI files. So this commit declares those
methods with normal method definitions in the RBI files to work around this
issue.
@kddnewton kddnewton merged commit 82fd925 into ruby:main Apr 19, 2024
54 checks passed
@kddnewton kddnewton deleted the avoid-attr-reader-in-rbi-files branch April 19, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants