-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build system to use Meson #206
Conversation
Uff, tests are finally green. |
Would you agree to engage yourself to maintain this for the years to come ? |
meson is a widely used and documented, unlike our present system to build this. besides, currently used |
So we both agree that it's a good idea to merge, right ? |
That's hard to promise but yes I'm willing to (help) maintaining it. The meson build info is also pretty straightforward, so it shouldn't be too hard for someone else to modify it. Please merge #209 before this one here, and squash this PR to have a cleaner git history. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @dimpase and @fchapoton! |
Following the example of Scipy/Numpy and sagemath/sage#36524, the build system is migrated to Meson.
I tried to stay as close as possible to the original autoconf implementation. A few differences are:
signals.pxd
, but have it at as a normal source file.Sage Developers
to align with the main sage repo. I'm unsure about this one and happy to revert it.MINSIGSTKSZ_IS_CONSTANT
(I had trouble making it compile and it's not constant for recent versions of glibc anyway)implementation_cygwin.c
directly inimplementation.c
since I was not able to make it compile (it's also a bit hard for me to work on the cygwin code since I only have the ci to test it.)Closes #179 (obsolete now)