Safely build 64-bit binaries along with some modernization. #412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-req contains several changes to come over 32-bit/64-bit situation of new Google Play's policy.
Changes made:
APP_ABI
because recent NDK lacks support for themall
is reasonable especially for recent NDKs because at least NDK r18 complainsarmeabi
is deprecated.versionBuildTool
to align build tools with Android gradle pluginhttps
instead ofhttp
for URI schema of libcommon to avoid possible DNS poisoning attackNote: According to recent Google's annoucements, APK size issue addressed here is meant to be mitigated via Android App Bundle.
Note: You will see
Android NDK: android-14 is unsupported. Using minimum supported version android-16.
warning when built with NDK r18 but you can easilly fix this by specifying older NDKs onlocal.properties
file if you really need to keep support for Android 4.0.x. I assume most developers (targetting android-16+) can harmlessly ignore this warning because their app themselves will be compiled withminSdkVersion 16
or later.