fix: sdist.exclude takes precedence over .gitignore #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, sdist.exclude and the built-in EXCLUDE_LINES were prepended to the list of .gitignore rules. However, a common pattern of using * to exclude everything and then using !-rules to list what should be included renders this feature useless. This commit changes the behavior of each_unignored_file to sequentially consider the following sets of independent rules: 1. Explicit inclusions 2. Explicit exclusions 3. Global exclusions from the .gitignore files 4. The built-in exclusions 5. Nested exclusions from .gitignore Fixes scikit-build#871
henryiii
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
==========================================
+ Coverage 83.98% 84.01% +0.02%
==========================================
Files 74 74
Lines 4372 4378 +6
==========================================
+ Hits 3672 3678 +6
Misses 700 700 ☔ View full report in Codecov by Sentry. |
|
@henryiii -- I'm not understanding what failed in the CI runs or why. Can you take a look, please? |
|
GHA was down: https://www.githubstatus.com |
henryiii
approved these changes
Aug 22, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, sdist.exclude and the built-in EXCLUDE_LINES were prepended to the list of .gitignore rules. However, a common pattern of using * to exclude everything and then using !-rules to list what should be included renders this feature useless.
This commit changes the behavior of each_unignored_file to sequentially consider the following sets of independent rules:
Fixes #871