Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sdist.exclude takes precedence over .gitignore #872

Merged
merged 1 commit into from
Aug 22, 2024

Commits on Aug 22, 2024

  1. sdist.exclude takes precedence over .gitignore

    Previously, sdist.exclude and the built-in EXCLUDE_LINES were prepended
    to the list of .gitignore rules. However, a common pattern of using *
    to exclude everything and then using !-rules to list what should be
    included renders this feature useless.
    
    This commit changes the behavior of each_unignored_file to sequentially
    consider the following sets of independent rules:
    
    1. Explicit inclusions
    2. Explicit exclusions
    3. Global exclusions from the .gitignore files
    4. The built-in exclusions
    5. Nested exclusions from .gitignore
    
    Fixes scikit-build#871
    alexreinking committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    3f0bfb0 View commit details
    Browse the repository at this point in the history