Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

fix: placeholders not replaced in resource params #55

Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix: placeholders not replaced in resource params #55

merged 1 commit into from
Aug 23, 2023

Conversation

chrishumanitec
Copy link
Contributor

It is expected that params in resourtces undergo placeholder replacement. This PR does this.

What does this PR do?

Performs SubstituteAll on app parms in resources,

Types of changes

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

@chrishumanitec
fix: placeholders not replaced in resource params
0ab2754 
Signed-off-by: Chris Stephenson <chris.stephenson@humanitec.com>
ghen
ghen approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@ghen ghen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to mention in CLI tool documentation that we now do substitution in resources params section. @rachfop

@ghen ghen merged commit 069dcdf into main Aug 23, 2023
3 checks passed
@ghen ghen deleted the placeholders-in-res-params branch August 23, 2023 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ghen ghen ghen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrishumanitec @ghen