-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEB: Added SEO functionality #393
base: master
Are you sure you want to change the base?
Conversation
1. Switched to SEO title 2. Added SEO meta description 3. Switched to SEO og:title 4. Switched to SEO og:description 5. Switched to SEO og:url 6. Added SEO canonical URL
Thank you for your PR. |
Thanks, but while your other approach adds certain features (which mine didn't) it simply ignores others. So why not just edit my PR to merge both of our features? Otherwise your approach means:
|
First, I am not fond of editing others' work behind their back. Besides, your PR as it is doesn't work at all: there is a syntax error and cutting the line doesn't work for a reason I didn't investigate. I suspect you didn't try it in a development environment. Finally, as I rewrote a big part of your PR, the only thing remaining is the fix for the URLs: that's not really an iteration over your work anymore. So pushing on your PR would be like a false pretense.
IMHO what is OpenGraph and what is not is not really significant. All of these are web page headers to help other websites to render the page.
When I first tested your PR, I noticed that content_title was not the most adequate as it added redundancy in the browser title (for example in the screenshots page, it says After looking at it more, it may help rendering of search results in Bing (interestingly, Google seems to choose a better title than us).
Because your solution doesn't work where I didn't set a description.
Because content_title is a duplicate in the cases where a subtitle is not set. |
Plus you did fix |
Currently ScummVM doesn't use any SEO, meaning if you share pages they all externally preview as if you shared just the homepage, so therefore:
This should solve this ticket, but only the site owners can preview this, so please check first it works well for the homepage, articles, compatibility, etc.
I'm auto generating the description based on the same
substr
principle as in https://github.com/scummvm/scummvm-web/blob/master/templates/components/list_items.tpl