Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB: Improve OpenGraph and SEO headers and fix news title #411

Merged
merged 5 commits into from
Sep 14, 2024

Conversation

lephilousophe
Copy link
Member

Improve the OpenGraph result by diversifying the description and the title.
This is done by adding more template parameters that each Controller sets to the proper value depending on the context.
This allows a better rendering than in #393.

@lwcorp
Copy link

lwcorp commented Sep 6, 2024

"better" is a subjective term. For example, I've fixed <title> while you didn't. I've also found a way to dynamically generate a meta description on the fly, which could be served as else to your check of if isset($description).
Other differences are in here - as suggested there, why not just editing it to add your features there, and thus enjoy both my features and yours?

In any case, please apply your own fix of og:title also to <title>.

@lephilousophe lephilousophe changed the title WEB: Improve OpenGraph headers WEB: Improve OpenGraph headers and fix news title Sep 8, 2024
@lephilousophe lephilousophe changed the title WEB: Improve OpenGraph headers and fix news title WEB: Improve OpenGraph and SEO headers and fix news title Sep 8, 2024
@lephilousophe
Copy link
Member Author

This is updated to add subtitle to the page title.
In addition, the news page title gains a dedicated string. There is now Home for the home page and Latest developments (ripped from the content title) for the news archive page.
This title can be changed afterwards.

@lephilousophe
Copy link
Member Author

Merging now.
I just added a change so that the page description when showing a game compatibility is the compatibility status.
This will allow to link a game compatibility page and get a nice "Game has no known issue" in the preview.

@lephilousophe lephilousophe merged commit 047655f into scummvm:master Sep 14, 2024
@lwcorp
Copy link

lwcorp commented Sep 14, 2024

Though it's merged it seems it's still not live, do you happen to know the ETA? Update: took the merge about half a day to go live.
BTW, out of curiosity how were you able to get write access, which is required for assigning reviewers and merging?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants