Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call string replace on an empty dataframe #485

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

lajohn4747
Copy link
Contributor

CU-86ayjeuuy
resolves #476

Crash is caused by a string replace method on an empty dataframe. Adding an empty check and continue the _generate_details method for intertables.

@lajohn4747 lajohn4747 requested a review from a team as a code owner October 26, 2023 17:44
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f39ca7) 76.99% compared to head (888897c) 77.07%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
+ Coverage   76.99%   77.07%   +0.08%     
==========================================
  Files          93       93              
  Lines        3412     3416       +4     
==========================================
+ Hits         2627     2633       +6     
+ Misses        785      783       -2     
Files Coverage Δ
...orts/multi_table/_properties/inter_table_trends.py 100.00% <100.00%> (ø)
...cs/single_column/statistical/boundary_adherence.py 100.00% <100.00%> (+9.52%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lajohn4747 lajohn4747 merged commit b1853d9 into main Oct 27, 2023
45 checks passed
@lajohn4747 lajohn4747 deleted the issue-476-empty-df-generate-details branch October 27, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intertable trends property crashes if a table has no statistical columns
4 participants