Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call string replace on an empty dataframe #485

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Don't call string replace on an empty dataframe #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0894da3
Don't call string replace on an empty dataframe
lajohn4747 Oct 26, 2023
888897c
Add unit test to catch empty dataframe due to no categorical data
lajohn4747 Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sdmetrics/reports/multi_table/_properties/inter_table_trends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,13 @@ def _generate_details(self, real_data, synthetic_data, metadata, progress_bar=No
denormalized_real, denormalized_synthetic, merged_metadata,
progress_bar=progress_bar, column_pairs=parent_child_pairs
)

details['Parent Table'] = parent
details['Child Table'] = child
details['Foreign Key'] = foreign_key
details['Column 1'] = details['Column 1'].str.replace(f'{parent}.', '', n=1)
details['Column 2'] = details['Column 2'].str.replace(f'{child}.', '', n=1)

if not details.empty:
details['Column 1'] = details['Column 1'].str.replace(f'{parent}.', '', n=1)
details['Column 2'] = details['Column 2'].str.replace(f'{child}.', '', n=1)
amontanez24 marked this conversation as resolved.
Show resolved Hide resolved
all_details.append(details)

self.details = pd.concat(all_details, axis=0).reset_index(drop=True)
Expand Down
120 changes: 120 additions & 0 deletions tests/unit/reports/multi_table/_properties/test_inter_table_trends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,126 @@ def test__generate_details(column_pair_trends_mock):
pd.testing.assert_frame_equal(instance.details, expected_details)


@patch('sdmetrics.reports.multi_table._properties.inter_table_trends.SingleTableColumnPairTrends')
def test__generate_details_empty_column_generate(column_pair_trends_mock):
"""Test the ``get_score`` method."""
# Setup
instance = InterTableTrends()
real_user_df = pd.DataFrame({
'user_id': ['user1', 'user2'],
})
synthetic_user_df = pd.DataFrame({
'user_id': ['user1', 'user2'],
})
real_session_df = pd.DataFrame({
'session_id': ['session1', 'session2', 'session3'],
'user_id': ['user1', 'user1', 'user2'],
})
synthetic_session_df = pd.DataFrame({
'session_id': ['session1', 'session2', 'session3'],
'user_id': ['user1', 'user1', 'user2'],
})

metadata = {
'tables': {
'users': {
'primary_key': 'user_id',
'columns': {
'user_id': {'sdtype': 'id'}
},
},
'sessions': {
'primary_key': 'session_id',
'columns': {
'session_id': {'sdtype': 'id'},
'user_id': {'sdtype': 'id'}
}
}
},
'relationships': [
{
'parent_table_name': 'users',
'child_table_name': 'sessions',
'parent_primary_key': 'user_id',
'child_foreign_key': 'user_id'
}
]
}
instanced_mock = column_pair_trends_mock.return_value
instanced_mock._generate_details.return_value = pd.DataFrame({
'Column 1': [],
'Column 2': [],
'Metric': [],
'Score': [],
'Real Correlation': [],
'Synthetic Correlation': [],
'Error': []
})

# Run
instance._generate_details(
real_data={'users': real_user_df, 'sessions': real_session_df},
synthetic_data={'users': synthetic_user_df, 'sessions': synthetic_session_df},
metadata=metadata
)

# Assert
expected_denormalized_real = pd.DataFrame({
'sessions.session_id': ['session1', 'session2', 'session3'],
'sessions.user_id': ['user1', 'user1', 'user2'],
'users.user_id': ['user1', 'user1', 'user2'],
})
expected_denormalized_synthetic = pd.DataFrame({
'sessions.session_id': ['session1', 'session2', 'session3'],
'sessions.user_id': ['user1', 'user1', 'user2'],
'users.user_id': ['user1', 'user1', 'user2'],
})
expected_merged_metadata = {
'primary_key': 'sessions.session_id',
'columns': {
'sessions.session_id': {'sdtype': 'id'},
'sessions.user_id': {'sdtype': 'id'},
'users.user_id': {'sdtype': 'id'},
},
}
expected_column_pairs = itertools.product(
['users.user_id'],
['sessions.session_id', 'sessions.user_id']
)
expected_details = pd.DataFrame({
'Parent Table': [],
'Child Table': [],
'Foreign Key': [],
'Column 1': [],
'Column 2': [],
'Metric': [],
'Score': [],
'Real Correlation': [],
'Synthetic Correlation': [],
'Error': []
}).astype({
'Parent Table': 'object',
'Child Table': 'object',
'Foreign Key': 'object',
'Column 1': 'float64',
'Column 2': 'float64',
'Metric': 'float64',
'Score': 'float64',
'Real Correlation': 'float64',
'Synthetic Correlation': 'float64',
'Error': 'float64'
})

instanced_mock._generate_details.assert_called_once_with(
DataFrameMatcher(expected_denormalized_real),
DataFrameMatcher(expected_denormalized_synthetic),
expected_merged_metadata,
progress_bar=None,
column_pairs=IteratorMatcher(expected_column_pairs)
)
pd.testing.assert_frame_equal(instance.details, expected_details)


@patch('sdmetrics.reports.multi_table._properties.inter_table_trends.px')
def test_get_visualization(plotly_mock):
"""Test the ``get_visualization`` method."""
Expand Down
Loading