Improve warning handling for non-positive values when apply_log = True for InterRowMSAS
#671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
requested review from
gsheni and
pvk-developer
and removed request for
a team
fealho
force-pushed
the
issue-670-warnings-log
branch
from
c8039a4 to
d00a3d7
Compare
gsheni
reviewed
Nov 21, 2024
| or len(data) != 2 | ||
| or (not (isinstance(data[0], pd.Series) and isinstance(data[1], pd.Series))) | ||
| ): | ||
| raise ValueError('The data must be a tuple of two pandas series.') |
There was a problem hiding this comment.
Should we added tests for these 3 exceptions?
There was a problem hiding this comment.
The tests have already been implemented. This change simply reorganizes the function for readability.
gsheni
approved these changes
Nov 21, 2024
pvk-developer
approved these changes
Nov 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
==========================================
- Coverage 94.13% 94.11% -0.03%
==========================================
Files 105 105
Lines 3921 3941 +20
==========================================
+ Hits 3691 3709 +18
- Misses 230 232 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86b2xa92t, Resolve #670.