enhancement: Handle multiple group edgecases #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alborrajo
approved these changes
Sep 17, 2024
Arrowgene.Ddon.Shared/Entity/PacketStructure/S2CEntryBoardEntryBoardExtendTimeoutRes.cs
Outdated
Show resolved
Hide resolved
Arrowgene.Ddon.Shared/Entity/PacketStructure/C2SEntryBoardEntryBoardExtendTimeoutReq.cs
Outdated
Show resolved
Hide resolved
- Created a new class UniqueIdPool to help with creating a pool of reusable 32bit IDs. - Created a new class TimerManager to help with generically using timers across the code base. - Added a timeout to board recruitment. - Added a timeout to board ready up. - Added the ability to kick a member from the entry board. - Added the ability to extend the ready up time. - Enhanced the vote to abandon content mechanism such that it will approve or reject the vote as soon as all members have voted. - Found the proper NTC to end the group content. - Synced timers shown in various UI elements so that they closer match the actual timer on the server. - Refactored existing classes to use new UniqueIdPool and TimerManager classes.
- Renamed packets missing "Item". - Replaced literals with constant.
pacampbell
force-pushed
the
exm_exploration
branch
from
a0f64d2
to
9fa0493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
developbranch