Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: Handle multiple group edgecases #559

Merged
merged 2 commits into from
Sep 17, 2024
Merged

enhancement: Handle multiple group edgecases #559

merged 2 commits into from
Sep 17, 2024

Commits on Sep 17, 2024

  1. enhancement: Handle multiple group edgecases 

    - Created a new class UniqueIdPool to help with creating a pool of
  reusable 32bit IDs.
- Created a new class TimerManager to help with generically using timers
  across the code base.
- Added a timeout to board recruitment.
- Added a timeout to board ready up.
- Added the ability to kick a member from the entry board.
- Added the ability to extend the ready up time.
- Enhanced the vote to abandon content mechanism such that it will
  approve or reject the vote as soon as all members have voted.
- Found the proper NTC to end the group content.
- Synced timers shown in various UI elements so that they closer match
  the actual timer on the server.
- Refactored existing classes to use new UniqueIdPool and TimerManager
  classes.
    @pacampbell
    pacampbell committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4ebb97a View commit details
    Browse the repository at this point in the history

  2. Code Review Feedback 

    - Renamed packets missing "Item".
- Replaced literals with constant.
    @pacampbell
    pacampbell committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    9fa0493 View commit details
    Browse the repository at this point in the history