Clean up toolchain registration #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
clean-up-toolchains
branch
2 times, most recently
from
7767291
to
0398f6c
Compare
If `graalvm_repository`'s `toolchain` argument is `False`, a toolchain for use with `native_image` should still be generated. Signed-off-by: Fabian Meumertzheim <fabian@meumertzhe.im>
fmeum
force-pushed
the
clean-up-toolchains
branch
from
0398f6c
to
137c9bc
Compare
fmeum
changed the title
Custom Java runtimes (those neither defined by the user nor rules_java) should not match on `--java_runtime_version` set to a version without a prefix as that can result in unexpected Java toolchain resolution results. By making this change now, we can consider registering both Java and GVM toolchains automatically with Bzlmod in follow-up changes. Signed-off-by: Fabian Meumertzheim <fabian@meumertzhe.im>
fmeum
force-pushed
the
clean-up-toolchains
branch
from
7bbaec5
to
6e90ca1
Compare
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
sgammon
approved these changes
Sep 11, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.