Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up toolchain registration #124

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Clean up toolchain registration #124

merged 2 commits into from
Sep 19, 2023

Commits on Sep 11, 2023

  1. fix: always create GraalVM native toolchain 

    If `graalvm_repository`'s `toolchain` argument is `False`, a toolchain
for use with `native_image` should still be generated.

Signed-off-by: Fabian Meumertzheim <fabian@meumertzhe.im>
    @fmeum
    fmeum committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    137c9bc View commit details
    Browse the repository at this point in the history

  2. fix!: remove --java_runtime_version match on version only 

    Custom Java runtimes (those neither defined by the user nor rules_java)
should not match on `--java_runtime_version` set to a version without a
prefix as that can result in unexpected Java toolchain resolution
results.

By making this change now, we can consider registering both Java and GVM
toolchains automatically with Bzlmod in follow-up changes.

Signed-off-by: Fabian Meumertzheim <fabian@meumertzhe.im>
    @fmeum
    fmeum committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    6e90ca1 View commit details
    Browse the repository at this point in the history