fix(toolchain): add alias indirection for gvm toolchain
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix: add `gvm` toolchain to toolchain config repo
- fix: add aliases from `graalvm` → toolchain targets
- fix: adjust instructions for registering toolchains
- fix: adjust workspace toolchain registration logic
Breaking change:
When registering toolchains in a Bzlmod installation of these rules,
the target `@graalvm//:all` must be changed to two toolchain
registrations, based on the desired functionality:
Register the Java toolchain:
register_toolchains("@graalvm//:jvm")
Register the GVM toolchain:
register_toolchains("@graalvm//:sdk")
Fixes and closes #66.
Relates-To: #66
Signed-off-by: Sam Gammon <sam@elide.ventures>
sgammon
added
enhancement
sgammon
changed the title
gvm toolchaingvm toolchain
Merged
Signed-off-by: Sam Gammon <sam@elide.ventures>
|
Kudos, SonarCloud Quality Gate passed!
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changeset adds
aliastargets and an additional level of indirection behind the GVM toolchain, to match the Java toolchain structure, as requested in #66.Breaking changes
When registering toolchains in a Bzlmod installation of these rules, the target
@graalvm//:allmust be changed to two toolchain registrations, based on the desired functionality:Register the Java toolchain:
Register the GVM toolchain:
Fixes and closes #66. Targeting release in #80.