Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toolchain): add alias indirection for gvm toolchain #82

Merged
merged 2 commits into from
Sep 1, 2023
Merged

fix(toolchain): add alias indirection for gvm toolchain #82

merged 2 commits into from
Sep 1, 2023

Commits on Sep 1, 2023

  1. fix!: add alias indirection for gvm toolchain 

    - fix: add `gvm` toolchain to toolchain config repo
- fix: add aliases from `graalvm` → toolchain targets
- fix: adjust instructions for registering toolchains
- fix: adjust workspace toolchain registration logic

Breaking change:
When registering toolchains in a Bzlmod installation of these rules,
the target `@graalvm//:all` must be changed to two toolchain
registrations, based on the desired functionality:

  Register the Java toolchain:
  register_toolchains("@graalvm//:jvm")

  Register the GVM toolchain:
  register_toolchains("@graalvm//:sdk")

Fixes and closes #66.

Relates-To: #66
Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    463ebbf View commit details
    Browse the repository at this point in the history

  2. fix: run pr tests on non-mainline merge base 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    f12911f View commit details
    Browse the repository at this point in the history