Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom artifact coordinates (wip) #87

Closed
wants to merge 27 commits into from
Closed

feat: custom artifact coordinates (wip) #87

wants to merge 27 commits into from

Conversation

sgammon
Copy link
Owner

@sgammon sgammon commented Sep 1, 2023

Summary

Add a mechanism to define custom SDK artifacts. More coming soon.

Related issues:

Changelog

  • feat: add macros for defining structs which describe custom SDK and/or component artifacts

fmeum and others added 27 commits August 31, 2023 23:39
@fmeum @sgammon
fix(native_image): fix C++ toolchain env setup
8887fee 
Instead of relying on the default shell env, get the environment
variables declared by the C++ toolchain. On macOS, additionally use
`apple_support` to pass in `DEVELOPER_DIR`.

Since GraalVM sanitizes the environment, all variables are translated
into `-E` flags.

Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: wrapped env-injection callable
4b376fd 
- fix: move `lambda` to nested function declaration

Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: refactor to split classic vs modern rules
571498a 
- fix: unwind combined implementation of classic/modern rules
- fix: classic rules should preserve older functionality
- fix: modern rules should use modern toolchain env
- fix: wrapped/injected `env` while still supporting bazel4
- chore: re-factor commons between old/new rules

Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: cleanup after rule internal refactor
f2da012 
- fix: use legacy rules from legacy gvm
- chore: drop `MODULE-resolved.bzl`
- chore: update bzlmod lock
- chore: update lib/docs deps and rebuild docs
- chore: remove redundant calls in sample projects

Applied on top of #72

Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: compile environment for msvc/native-image
d4b1e42 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: refactor/extract native cc resolution logic
e438724 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: general cleanup
96bc342 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: run buildifier
0c33c04 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: don't build/test tools by default
eaf3c50 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: make test should run all tests
fd57146 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: use default shell env on linux, too
a435f22 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: update bzlmod locks
8af111e 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: default_executable_name → executable_name
efca056 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: no default tool for modern rules
2b7836f 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: rebuild apidoc
426cea5 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@fmeum @sgammon
feat(native_image): add static_zlib
31e31e0 
When provided, the static zlib library will be used when Graal
statically links in zlib.

Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: run buildifier
2ae10ac 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: rollback use_default_shell_env, remove msvc vars from tests
743979a 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@fmeum
fix: fix modern build on Windows by adding cmd.exe to PATH
6303fd6 
Signed-off-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@fmeum
fix(native_image): add missing _linux_constraint attribute
44c9792 
Signed-off-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@sgammon
fix!: add alias indirection for gvm toolchain
06e2f83 
- fix: add `gvm` toolchain to toolchain config repo
- fix: add aliases from `graalvm` → toolchain targets
- fix: adjust instructions for registering toolchains
- fix: adjust workspace toolchain registration logic

Breaking change:
When registering toolchains in a Bzlmod installation of these rules,
the target `@graalvm//:all` must be changed to two toolchain
registrations, based on the desired functionality:

  Register the Java toolchain:
  register_toolchains("@graalvm//:jvm")

  Register the GVM toolchain:
  register_toolchains("@graalvm//:sdk")

Fixes and closes #66.

Relates-To: #66
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: run pr tests on non-mainline merge base
5de7f5f 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
test: add more feature integration tests
2ef29bb 
- test: add `java-toolchain` test, which exercises graalvm as the
  bazel tool/runtime java toolchain.

- test: add `components-ce` test, which downloads GVM Community
  components with dependencies.

- test: add `components-gvm` test, which downloads Oracle GVM
  components with `gu`.

- test: add `disabled_tests` with tests for earlier versions of
  bazel (coming soon), including `bazel1`, `bazel2`, and `bazel3`

- test: move most tests to GVM Community (except where noted)

Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: default value for distribution
2b813e1 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: don't set BAZEL_USE_CPP_ONLY_TOOLCHAIN in testing
8df8167 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
docs: document graalvm_repository attributes
e21a0f4 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
feat: custom artifact coordinates (wip)
f9ab083 
- feat: add macros for defining structs which describe custom SDK
  and/or component artifacts

Relates-To: #83
Relates-To: #53
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon sgammon added feature Mainline feature work 🚧 WIP Work-in-progress, do not merge labels Sep 1, 2023
@sgammon sgammon added this to the 1.0.0 milestone Sep 1, 2023
@sgammon sgammon self-assigned this Sep 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sgammon sgammon force-pushed the release/0.10.x branch 3 times, most recently from 407c2e2 to 0b12c7c Compare September 8, 2023 04:40
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sgammon
Copy link
Owner Author

sgammon commented Jan 6, 2024

picking this up again later

@sgammon sgammon closed this Jan 6, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sgammon sgammon

Labels
feature Mainline feature work 🚧 WIP Work-in-progress, do not merge
Projects
GraalVM Rules for Bazel
Status: Done
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sgammon @CLAassistant @fmeum