Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom artifact coordinates (wip) #87

Closed
wants to merge 27 commits into from
Closed

feat: custom artifact coordinates (wip) #87

wants to merge 27 commits into from

Commits on Sep 1, 2023

  1. fix(native_image): fix C++ toolchain env setup 

    Instead of relying on the default shell env, get the environment
variables declared by the C++ toolchain. On macOS, additionally use
`apple_support` to pass in `DEVELOPER_DIR`.

Since GraalVM sanitizes the environment, all variables are translated
into `-E` flags.

Signed-off-by: Sam Gammon <sam@elide.ventures>
    @fmeum @sgammon
    fmeum authored and sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    8887fee View commit details
    Browse the repository at this point in the history

  2. fix: wrapped env-injection callable 

    - fix: move `lambda` to nested function declaration

Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    4b376fd View commit details
    Browse the repository at this point in the history

  3. fix: refactor to split classic vs modern rules 

    - fix: unwind combined implementation of classic/modern rules
- fix: classic rules should preserve older functionality
- fix: modern rules should use modern toolchain env
- fix: wrapped/injected `env` while still supporting bazel4
- chore: re-factor commons between old/new rules

Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    571498a View commit details
    Browse the repository at this point in the history

  4. fix: cleanup after rule internal refactor 

    - fix: use legacy rules from legacy gvm
- chore: drop `MODULE-resolved.bzl`
- chore: update bzlmod lock
- chore: update lib/docs deps and rebuild docs
- chore: remove redundant calls in sample projects

Applied on top of #72

Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    f2da012 View commit details
    Browse the repository at this point in the history

  5. fix: compile environment for msvc/native-image 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    d4b1e42 View commit details
    Browse the repository at this point in the history

  6. chore: refactor/extract native cc resolution logic 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    e438724 View commit details
    Browse the repository at this point in the history

  7. chore: general cleanup 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    96bc342 View commit details
    Browse the repository at this point in the history

  8. chore: run buildifier 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    0c33c04 View commit details
    Browse the repository at this point in the history

  9. fix: don't build/test tools by default 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    eaf3c50 View commit details
    Browse the repository at this point in the history

  10. fix: make test should run all tests 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    fd57146 View commit details
    Browse the repository at this point in the history

  11. fix: use default shell env on linux, too 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    a435f22 View commit details
    Browse the repository at this point in the history

  12. chore: update bzlmod locks 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    8af111e View commit details
    Browse the repository at this point in the history

  13. chore: default_executable_name → executable_name 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    efca056 View commit details
    Browse the repository at this point in the history

  14. fix: no default tool for modern rules 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    2b7836f View commit details
    Browse the repository at this point in the history

  15. chore: rebuild apidoc 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    426cea5 View commit details
    Browse the repository at this point in the history

  16. feat(native_image): add static_zlib 

    When provided, the static zlib library will be used when Graal
statically links in zlib.

Signed-off-by: Sam Gammon <sam@elide.ventures>
    @fmeum @sgammon
    fmeum authored and sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    31e31e0 View commit details
    Browse the repository at this point in the history

  17. chore: run buildifier 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    2ae10ac View commit details
    Browse the repository at this point in the history

  18. fix: rollback use_default_shell_env, remove msvc vars from tests 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    743979a View commit details
    Browse the repository at this point in the history

  19. fix: fix modern build on Windows by adding cmd.exe to PATH 

    Signed-off-by: Fabian Meumertzheim <fabian@meumertzhe.im>
    @fmeum
    fmeum committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    6303fd6 View commit details
    Browse the repository at this point in the history

  20. fix(native_image): add missing _linux_constraint attribute 

    Signed-off-by: Fabian Meumertzheim <fabian@meumertzhe.im>
    @fmeum
    fmeum committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    44c9792 View commit details
    Browse the repository at this point in the history

  21. fix!: add alias indirection for gvm toolchain 

    - fix: add `gvm` toolchain to toolchain config repo
- fix: add aliases from `graalvm` → toolchain targets
- fix: adjust instructions for registering toolchains
- fix: adjust workspace toolchain registration logic

Breaking change:
When registering toolchains in a Bzlmod installation of these rules,
the target `@graalvm//:all` must be changed to two toolchain
registrations, based on the desired functionality:

  Register the Java toolchain:
  register_toolchains("@graalvm//:jvm")

  Register the GVM toolchain:
  register_toolchains("@graalvm//:sdk")

Fixes and closes #66.

Relates-To: #66
Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    06e2f83 View commit details
    Browse the repository at this point in the history

  22. fix: run pr tests on non-mainline merge base 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    5de7f5f View commit details
    Browse the repository at this point in the history

  23. test: add more feature integration tests 

    - test: add `java-toolchain` test, which exercises graalvm as the
  bazel tool/runtime java toolchain.

- test: add `components-ce` test, which downloads GVM Community
  components with dependencies.

- test: add `components-gvm` test, which downloads Oracle GVM
  components with `gu`.

- test: add `disabled_tests` with tests for earlier versions of
  bazel (coming soon), including `bazel1`, `bazel2`, and `bazel3`

- test: move most tests to GVM Community (except where noted)

Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    2ef29bb View commit details
    Browse the repository at this point in the history

  24. fix: default value for distribution 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    2b813e1 View commit details
    Browse the repository at this point in the history

  25. fix: don't set BAZEL_USE_CPP_ONLY_TOOLCHAIN in testing 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    8df8167 View commit details
    Browse the repository at this point in the history

  26. docs: document graalvm_repository attributes 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    e21a0f4 View commit details
    Browse the repository at this point in the history

  27. feat: custom artifact coordinates (wip) 

    - feat: add macros for defining structs which describe custom SDK
  and/or component artifacts

Relates-To: #83
Relates-To: #53
Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    f9ab083 View commit details
    Browse the repository at this point in the history