[BSS-72] Resolve the issue related external embed wrong serialization and publish patch #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Client dependency to External constructor for future use - Restructure jsonSerialize output to match required format - Wrap external data in 'external' property according to spec - Update unit tests to reflect new structure - Fix array formatting and indentation in tests This commit addresses an issue where external embeds weren't being structured according to AT Protocol specifications, which requires external data to be nested under an 'external' property.
shahmal1yev
changed the title
shahmal1yev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #18 where the link preview functionality wasn't working due to incorrect external embed serialization structure. This PR fixes the issue by properly structuring the external embed data according to AT Protocol specifications.