Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BSS-72] Resolve the issue related external embed wrong serialization and publish patch #19

Merged
merged 2 commits into from
Nov 11, 2024
Merged

[BSS-72] Resolve the issue related external embed wrong serialization and publish patch #19

merged 2 commits into from
Nov 11, 2024

Commits on Nov 11, 2024

  1. Resolve the issue that external does not serialize by atproto/bsky specs 

    - Add Client dependency to External constructor for future use
- Restructure jsonSerialize output to match required format
- Wrap external data in 'external' property according to spec
- Update unit tests to reflect new structure
- Fix array formatting and indentation in tests

This commit addresses an issue where external embeds weren't being
structured according to AT Protocol specifications, which requires
external data to be nested under an 'external' property.
    @shahmal1yev
    shahmal1yev committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    58bc75d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into bss-issue-18

    @shahmal1yev
    shahmal1yev committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    421aea1 View commit details
    Browse the repository at this point in the history