Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use latest out tx for all checks #6853

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

kaladinlight
Copy link
Contributor

Description

Follow up on: #6813

checkOutboundTxConfirmations was still using out_txs[0] instead of latestOutTx, so this change ensures everything is using the same out tx for status checks.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A

Risk

High Risk PRs Require 2 approvals

Medium - changes logic surrounded status updates for swaps

What protocols, transaction types or contract interactions might be affected by this PR?

Thorchain

Testing

See #6813

Engineering

☝️

Operations

☝️

Screenshots (if applicable)

@kaladinlight kaladinlight requested a review from a team as a code owner May 8, 2024 18:43
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me - tested locally:

L1 -> RUNE

image

RUNE -> L1

image

L1 -> L1

image

@kaladinlight kaladinlight merged commit 4acb55c into develop May 8, 2024
3 checks passed
@kaladinlight kaladinlight deleted the fix-thor-status-checks branch May 8, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants