fix: use latest out tx for all checks

src/lib/swapper/swappers/ThorchainSwapper/endpoints.ts

@@ -349,11 +349,11 @@ export const thorchainApi: SwapperApi = {
       const latestOutTx = data.out_txs?.[data.out_txs.length - 1]
       const hasOutboundTx = latestOutTx?.chain !== 'THOR'
 
-      const buyTxHash = parseThorBuyTxHash(txHash, data)
+      const buyTxHash = parseThorBuyTxHash(txHash, latestOutTx)
 
       // if we have an outbound transaction (non rune) and associated buyTxHash, check if it's been confirmed on-chain
       if (hasOutboundTx && buyTxHash) {
-        const outboundTxConfirmations = await checkOutboundTxConfirmations(data, buyTxHash)
+        const outboundTxConfirmations = await checkOutboundTxConfirmations(buyTxHash, latestOutTx)
 
         if (outboundTxConfirmations !== undefined && outboundTxConfirmations > 0) {
           return {

src/lib/swapper/swappers/ThorchainSwapper/types.ts

@@ -145,7 +145,7 @@ type ThorNodeCoinSchema = {
   decimals?: number
 }
 
-type ThorNodeTxSchema = {
+export type ThorNodeTxSchema = {
   id: string
   chain: ThorchainChain
   from_address: string

src/lib/swapper/swappers/ThorchainSwapper/utils/checkOutputTxConfirmations.ts

@@ -3,19 +3,17 @@ import axios from 'axios'
 import { getConfig } from 'config'
 import { assertUnreachable } from 'lib/utils'
 
-import type { ThorNodeStatusResponseSuccess } from '../types'
+import type { ThorNodeTxSchema } from '../types'
 import { ThorchainChain } from '../types'
 
 export const checkOutboundTxConfirmations = async (
-  thorTxData: ThorNodeStatusResponseSuccess,
   buyTxHash: string,
+  latestOutTx: ThorNodeTxSchema | undefined,
 ) => {
-  const outCoinChain: ThorchainChain | undefined = thorTxData.out_txs?.[0]?.chain
-
-  if (!outCoinChain) return
+  if (!latestOutTx) return
 
   const apiUrl = (() => {
-    switch (outCoinChain) {
+    switch (latestOutTx.chain) {
       case ThorchainChain.BTC: {
         return getConfig().REACT_APP_UNCHAINED_BITCOIN_HTTP_URL
       }
@@ -44,9 +42,9 @@ export const checkOutboundTxConfirmations = async (
         return getConfig().REACT_APP_UNCHAINED_COSMOS_HTTP_URL
       }
       case ThorchainChain.BSC:
-        throw Error(`${outCoinChain} not supported`)
+        throw Error(`${latestOutTx.chain} not supported`)
       default:
-        assertUnreachable(outCoinChain)
+        assertUnreachable(latestOutTx.chain)
     }
   })()
 

src/lib/swapper/swappers/ThorchainSwapper/utils/parseThorBuyTxHash.ts

@@ -1,13 +1,11 @@
-import type { ThorNodeStatusResponseSuccess } from '../types'
+import type { ThorNodeTxSchema } from '../types'
 
 const THORCHAIN_EVM_CHAINS = ['ETH', 'AVAX', 'BSC'] as const
 
 export const parseThorBuyTxHash = (
   sellTxId: string,
-  response: ThorNodeStatusResponseSuccess,
+  latestOutTx: ThorNodeTxSchema | undefined,
 ): string | undefined => {
-  const latestOutTx = response.out_txs?.[response.out_txs.length - 1]
-
   if (!latestOutTx) return
 
   // outbound rune transactions do not have a txid as they are processed internally, use sell txid