Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: defi section ledger open app gate #7628

Merged
merged 5 commits into from
Aug 27, 2024
Merged

feat: defi section ledger open app gate #7628

merged 5 commits into from
Aug 27, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Aug 27, 2024 •
edited
Loading

Description

This PR implements Ledger over all DeFi section signing actions.

Issue (if applicable)

closes #7579

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low to none

Testing

  • Ensure all signing actions across the DeFi section (deposit, withdraw, claim) are properly guarded by the Ledger Open App gate, i.e pop up a modal to open the relevant Ledger app if no/wrong app is opened
  • Test this over:
    • ETH/FOX (UNI-V2)
    • FOX Farming
    • FOXy
    • THORChain savers
    • Cosmos SDK

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

  • UNI-V2
Screenshot 2024-08-27 at 09 14 58 Screenshot 2024-08-27 at 09 14 41 Screenshot 2024-08-27 at 09 13 59 Screenshot 2024-08-27 at 09 13 50 Screenshot 2024-08-27 at 09 12 50 Screenshot 2024-08-27 at 09 12 29
  • FOX Farming
Screenshot 2024-08-27 at 09 28 09 Screenshot 2024-08-27 at 09 27 39
  • FOXy
Screenshot 2024-08-27 at 10 16 31 Screenshot 2024-08-27 at 10 07 03
  • THORChain Savers
Screenshot 2024-08-27 at 10 19 34 Screenshot 2024-08-27 at 10 18 35
  • Cosmos SDK
image image image

@gomesalexandre gomesalexandre requested a review from a team as a code owner August 27, 2024 08:22
@gomesalexandre gomesalexandre marked this pull request as draft August 27, 2024 08:22
@gomesalexandre gomesalexandre marked this pull request as ready for review August 27, 2024 09:04
@gomesalexandre gomesalexandre mentioned this pull request Aug 27, 2024
Closed
1 task
NeOMakinG
NeOMakinG approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thorchain savers, Fox Farming, Univ2: https://jam.dev/c/82228eea-9378-4aa8-b55b-6b5ce1abce12

I can't test foxy on my side!

Cosmos:
image

Working like a charm

@NeOMakinG NeOMakinG enabled auto-merge (squash) August 27, 2024 14:34
@NeOMakinG NeOMakinG merged commit ce240fa into develop Aug 27, 2024
3 checks passed
@NeOMakinG NeOMakinG deleted the feat_defi_ledger_gate branch August 27, 2024 14:40
@NeOMakinG NeOMakinG mentioned this pull request Aug 27, 2024
Merged
@gomesalexandre gomesalexandre mentioned this pull request Aug 27, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ledger open app gate in DeFi section
2 participants
@gomesalexandre @NeOMakinG