Improve logging and metrics for block publication #5699

michaelsproul · 2024-05-03T00:29:10Z

Proposed Changes

Print the block publish delay in milliseconds, which makes it easier to parse and process. This is a change that some relays have previously asked for.
Add a new metric tracking block gossip time in the HTTP API, which matches the publish_delay_ms log.
Fix Clippy for Rust 1.78 just released

michaelsproul · 2024-05-03T01:49:08Z

@Mergifyio queue

mergify · 2024-05-03T01:49:22Z

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

Squashed commit of the following: commit 0e3b0a1 Author: Michael Sproul <michael@sigmaprime.io> Date: Fri May 3 10:35:42 2024 +1000 Add better buckets commit 2f09bea Author: Michael Sproul <michael@sigmaprime.io> Date: Fri May 3 10:25:47 2024 +1000 Improve logging and metrics for block publication

michaelsproul · 2024-05-03T02:16:28Z

@Mergifyio requeue

mergify · 2024-05-03T02:16:33Z

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

mergify · 2024-05-03T02:16:34Z

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

michaelsproul · 2024-05-03T04:26:22Z

@Mergifyio requeue

mergify · 2024-05-03T04:26:27Z

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

mergify · 2024-05-03T04:26:28Z

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

jimmygchen · 2024-05-03T06:02:29Z

@mergify requeue

mergify · 2024-05-03T06:02:33Z

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

mergify · 2024-05-03T06:02:34Z

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

jimmygchen · 2024-05-03T06:47:52Z

@mergify requeue

mergify · 2024-05-03T06:47:55Z

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

mergify · 2024-05-03T06:47:56Z

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

jimmygchen · 2024-05-03T06:50:54Z

@mergify requeue

mergify · 2024-05-03T06:51:26Z

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

mergify · 2024-05-03T06:51:27Z

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

jimmygchen · 2024-05-03T07:33:35Z

@mergify requeue

mergify · 2024-05-03T07:33:47Z

❌ This pull request head commit has not been previously disembarked from queue.

jimmygchen · 2024-05-03T07:35:15Z

@mergify queue

mergify · 2024-05-03T07:35:20Z

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

jimmygchen · 2024-05-03T07:43:39Z

@mergify requeue

mergify · 2024-05-03T07:43:46Z

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

mergify · 2024-05-03T07:43:47Z

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

jimmygchen · 2024-05-03T07:46:26Z

@Mergifyio unqueue

mergify · 2024-05-03T07:46:30Z

☑️ The pull request is not queued

jimmygchen · 2024-05-03T07:47:52Z

@mergify requeue

mergify · 2024-05-03T07:47:55Z

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

mergify · 2024-05-03T07:47:56Z

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

jimmygchen · 2024-05-03T07:52:49Z

@mergify queue

mergify · 2024-05-03T07:53:32Z

✅ The pull request has been merged automatically

The pull request has been merged automatically at d3d429f

Improve logging and metrics for block publication

2f09bea

michaelsproul added the ready-for-review The code is ready for review label May 3, 2024

Add better buckets

0e3b0a1

pawanjay176 approved these changes May 3, 2024

View reviewed changes

michaelsproul added ready-for-merge This PR is ready to merge. v5.2.0 Q2 2024 and removed ready-for-review The code is ready for review labels May 3, 2024

michaelsproul mentioned this pull request May 3, 2024

web3Signer: set header "Accept: application/json" as we expect json in the response #5692

Merged

michaelsproul mentioned this pull request May 3, 2024

Release v5.2.0 #5664

Merged

mergify bot added a commit that referenced this pull request May 3, 2024

Merge of #5699

cdb7033

mergify bot mentioned this pull request May 3, 2024

merge queue: embarking unstable (ee974db) and [#5699 + #5692] together #5702

Closed

6 tasks

Bump SQL connection timeout for tests.

b700737

jimmygchen force-pushed the publish_block_ms branch from c5c73fe to b700737 Compare May 3, 2024 07:52

mergify bot merged commit d3d429f into sigp:unstable May 3, 2024
27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve logging and metrics for block publication #5699

Improve logging and metrics for block publication #5699

michaelsproul commented May 3, 2024

michaelsproul commented May 3, 2024

mergify bot commented May 3, 2024 •

edited

Loading

michaelsproul commented May 3, 2024

mergify bot commented May 3, 2024

mergify bot commented May 3, 2024 •

edited

Loading

michaelsproul commented May 3, 2024

mergify bot commented May 3, 2024

mergify bot commented May 3, 2024 •

edited

Loading

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

mergify bot commented May 3, 2024 •

edited

Loading

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

mergify bot commented May 3, 2024 •

edited

Loading

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

mergify bot commented May 3, 2024 •

edited

Loading

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024 •

edited

Loading

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

mergify bot commented May 3, 2024 •

edited

Loading

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

mergify bot commented May 3, 2024 •

edited

Loading

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024 •

edited

Loading

Improve logging and metrics for block publication #5699

Improve logging and metrics for block publication #5699

Conversation

michaelsproul commented May 3, 2024

Proposed Changes

michaelsproul commented May 3, 2024

mergify bot commented May 3, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

michaelsproul commented May 3, 2024

mergify bot commented May 3, 2024

✅ This pull request will be re-embarked automatically

mergify bot commented May 3, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

michaelsproul commented May 3, 2024

mergify bot commented May 3, 2024

✅ This pull request will be re-embarked automatically

mergify bot commented May 3, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

✅ This pull request will be re-embarked automatically

mergify bot commented May 3, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

✅ This pull request will be re-embarked automatically

mergify bot commented May 3, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

✅ This pull request will be re-embarked automatically

mergify bot commented May 3, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

❌ This pull request head commit has not been previously disembarked from queue.

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

✅ This pull request will be re-embarked automatically

mergify bot commented May 3, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

☑️ The pull request is not queued

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

✅ This pull request will be re-embarked automatically

mergify bot commented May 3, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024 • edited Loading

✅ The pull request has been merged automatically

mergify bot commented May 3, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented May 3, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented May 3, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented May 3, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented May 3, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented May 3, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented May 3, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented May 3, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented May 3, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented May 3, 2024 •

edited

Loading