DEP Limit PHP support for CMS 6 #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/6/php-83-only
branch
from
e7b4a0c
to
fb62537
Compare
GuySartorelli
commented
Aug 20, 2024
Comment on lines
+40
to
+42
| "conflict": { | ||
| "egulias/email-validator": "<3.2.6" | ||
| }, |
There was a problem hiding this comment.
Needed to fix https://github.com/silverstripe/silverstripe-contentreview/actions/runs/10447581437/job/29026521584?pr=250
- SilverStripe\ContentReview\Tests\ContentReviewNotificationTest::testContentReviewEmails
Symfony\Component\Mime\Exception\RfcComplianceException: Email "no-reply@localhost" does not comply with addr-spec of RFC 2822.
prefer-lowest is installing v3.1.0. Didn't go as far as to track the exact version of that library that fixes the bug - tried 3.1.2 and 3.2.0 and 3.2.6, the latter of which works as expected.
emteknetnz
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue