Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP Limit PHP support for CMS 6 #250

Merged
merged 1 commit into from
Aug 21, 2024
Merged

DEP Limit PHP support for CMS 6 #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
}
],
"require": {
"php": "^8.1",
"php": "^8.3",
"silverstripe/vendor-plugin": "^2",
"silverstripe/framework": "^6",
"silverstripe/cms": "^6",
Expand All @@ -37,6 +37,9 @@
"silverstripe/standards": "^1",
"phpstan/extension-installer": "^1.3"
},
"conflict": {
"egulias/email-validator": "<3.2.6"
},
Comment on lines +40 to +42
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to fix https://github.com/silverstripe/silverstripe-contentreview/actions/runs/10447581437/job/29026521584?pr=250

  1. SilverStripe\ContentReview\Tests\ContentReviewNotificationTest::testContentReviewEmails
    Symfony\Component\Mime\Exception\RfcComplianceException: Email "no-reply@localhost" does not comply with addr-spec of RFC 2822.

prefer-lowest is installing v3.1.0. Didn't go as far as to track the exact version of that library that fixes the bug - tried 3.1.2 and 3.2.0 and 3.2.6, the latter of which works as expected.

"suggest": {
"symbiote/silverstripe-queuedjobs": "Automatically schedules content review emails to be sent, only requiring one crontask to be created"
},
Expand Down
Loading