refactor(be): admin problem and submission exception handling

.github/workflows/ci.yml

@@ -155,7 +155,7 @@ jobs:
         working-directory: ./apps/iris
 
       - name: Lint (Node.js)
-        run: git diff --name-only --diff-filter=ACMRUXB origin/main | grep -E "(.ts$|.tsx$|.js$|.jsx$)" | xargs -r pnpm eslint
+        run: git diff --name-only --diff-filter=ACMRUXB origin/main | grep -E "(.ts$|.tsx$|.js$|.jsx$)" | grep -v 'next.config.js$' | xargs -r pnpm eslint
 
   test-backend:
     name: Test Backend

apps/backend/Dockerfile

@@ -5,7 +5,7 @@
 ARG target=client
 ARG app_env=production
 
-FROM node:20.17.0-alpine AS builder
+FROM node:20.18.0-alpine AS builder
 ARG target
 
 COPY . /build
@@ -19,7 +19,7 @@ RUN npx prisma generate
 RUN npm run build ${target}
 
 ### PRODUCTION ###
-FROM node:20.17.0-alpine
+FROM node:20.18.0-alpine
 ARG target
 ARG app_env
 

apps/backend/apps/admin/src/contest/contest.resolver.ts

@@ -1,19 +1,8 @@
-import {
-  InternalServerErrorException,
-  Logger,
-  NotFoundException,
-  ParseBoolPipe
-} from '@nestjs/common'
+import { ParseBoolPipe } from '@nestjs/common'
 import { Args, Context, Int, Mutation, Query, Resolver } from '@nestjs/graphql'
 import { Contest, ContestProblem } from '@generated'
-import { PrismaClientKnownRequestError } from '@prisma/client/runtime/library'
 import { AuthenticatedRequest, UseRolesGuard } from '@libs/auth'
 import { OPEN_SPACE_ID } from '@libs/constants'
-import {
-  ConflictFoundException,
-  EntityNotExistException,
-  UnprocessableDataException
-} from '@libs/exception'
 import {
   CursorValidationPipe,
   GroupIDPipe,
@@ -34,7 +23,6 @@ import { UserContestScoreSummaryWithUserInfo } from './model/score-summary'
 
 @Resolver(() => Contest)
 export class ContestResolver {
-  private readonly logger = new Logger(ContestResolver.name)
   constructor(private readonly contestService: ContestService) {}
 
   @Query(() => [ContestWithParticipants])
@@ -62,16 +50,7 @@ export class ContestResolver {
     @Args('contestId', { type: () => Int }, new RequiredIntPipe('contestId'))
     contestId: number
   ) {
-    try {
-      return await this.contestService.getContest(contestId)
-    } catch (error) {
-      if (
-        error instanceof PrismaClientKnownRequestError &&
-        error.code == 'P2025'
-      ) {
-        throw new NotFoundException(error.message)
-      }
-    }
+    return await this.contestService.getContest(contestId)
   }
 
   @Mutation(() => Contest)
@@ -85,57 +64,23 @@ export class ContestResolver {
     groupId: number,
     @Context('req') req: AuthenticatedRequest
   ) {
-    try {
-      return await this.contestService.createContest(
-        groupId,
-        req.user.id,
-        input
-      )
-    } catch (error) {
-      if (
-        error instanceof UnprocessableDataException ||
-        error instanceof EntityNotExistException
-      ) {
-        throw error.convert2HTTPException()
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.contestService.createContest(groupId, req.user.id, input)
   }
 
   @Mutation(() => Contest)
   async updateContest(
     @Args('groupId', { type: () => Int }, GroupIDPipe) groupId: number,
     @Args('input') input: UpdateContestInput
   ) {
-    try {
-      return await this.contestService.updateContest(groupId, input)
-    } catch (error) {
-      if (
-        error instanceof EntityNotExistException ||
-        error instanceof UnprocessableDataException
-      ) {
-        throw error.convert2HTTPException()
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.contestService.updateContest(groupId, input)
   }
 
   @Mutation(() => Contest)
   async deleteContest(
     @Args('groupId', { type: () => Int }, GroupIDPipe) groupId: number,
     @Args('contestId', { type: () => Int }) contestId: number
   ) {
-    try {
-      return await this.contestService.deleteContest(groupId, contestId)
-    } catch (error) {
-      if (error instanceof EntityNotExistException) {
-        throw error.convert2HTTPException()
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.contestService.deleteContest(groupId, contestId)
   }
 
   @Query(() => [PublicizingRequest])
@@ -149,21 +94,10 @@ export class ContestResolver {
     @Args('groupId', { type: () => Int }, GroupIDPipe) groupId: number,
     @Args('contestId', { type: () => Int }) contestId: number
   ) {
-    try {
-      return await this.contestService.createPublicizingRequest(
-        groupId,
-        contestId
-      )
-    } catch (error) {
-      if (
-        error instanceof EntityNotExistException ||
-        error instanceof ConflictFoundException
-      ) {
-        throw error.convert2HTTPException()
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.contestService.createPublicizingRequest(
+      groupId,
+      contestId
+    )
   }
 
   @Mutation(() => PublicizingResponse)
@@ -172,18 +106,10 @@ export class ContestResolver {
     @Args('contestId', { type: () => Int }) contestId: number,
     @Args('isAccepted', ParseBoolPipe) isAccepted: boolean
   ) {
-    try {
-      return await this.contestService.handlePublicizingRequest(
-        contestId,
-        isAccepted
-      )
-    } catch (error) {
-      if (error instanceof EntityNotExistException) {
-        throw error.convert2HTTPException()
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.contestService.handlePublicizingRequest(
+      contestId,
+      isAccepted
+    )
   }
 
   @Mutation(() => [ContestProblem])
@@ -193,22 +119,11 @@ export class ContestResolver {
     @Args('problemIdsWithScore', { type: () => [ProblemScoreInput] })
     problemIdsWithScore: ProblemScoreInput[]
   ) {
-    try {
-      return await this.contestService.importProblemsToContest(
-        groupId,
-        contestId,
-        problemIdsWithScore
-      )
-    } catch (error) {
-      if (
-        error instanceof EntityNotExistException ||
-        error instanceof UnprocessableDataException
-      ) {
-        throw error.convert2HTTPException()
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.contestService.importProblemsToContest(
+      groupId,
+      contestId,
+      problemIdsWithScore
+    )
   }
 
   @Mutation(() => [ContestProblem])
@@ -218,22 +133,11 @@ export class ContestResolver {
     contestId: number,
     @Args('problemIds', { type: () => [Int] }) problemIds: number[]
   ) {
-    try {
-      return await this.contestService.removeProblemsFromContest(
-        groupId,
-        contestId,
-        problemIds
-      )
-    } catch (error) {
-      if (
-        error instanceof EntityNotExistException ||
-        error instanceof UnprocessableDataException
-      ) {
-        throw error.convert2HTTPException()
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.contestService.removeProblemsFromContest(
+      groupId,
+      contestId,
+      problemIds
+    )
   }
 
   /**
@@ -257,18 +161,13 @@ export class ContestResolver {
     @Args('cursor', { nullable: true, type: () => Int }, CursorValidationPipe)
     cursor: number | null
   ) {
-    try {
-      return await this.contestService.getContestSubmissionSummaryByUserId(
-        take,
-        contestId,
-        userId,
-        problemId,
-        cursor
-      )
-    } catch (error) {
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.contestService.getContestSubmissionSummaryByUserId(
+      take,
+      contestId,
+      userId,
+      problemId,
+      cursor
+    )
   }
 
   @Mutation(() => DuplicatedContestResponse)
@@ -278,22 +177,11 @@ export class ContestResolver {
     contestId: number,
     @Context('req') req: AuthenticatedRequest
   ) {
-    try {
-      return await this.contestService.duplicateContest(
-        groupId,
-        contestId,
-        req.user.id
-      )
-    } catch (error) {
-      if (
-        error instanceof UnprocessableDataException ||
-        error instanceof EntityNotExistException
-      ) {
-        throw error.convert2HTTPException()
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.contestService.duplicateContest(
+      groupId,
+      contestId,
+      req.user.id
+    )
   }
 
   /**
@@ -304,37 +192,27 @@ export class ContestResolver {
    */
   @Query(() => [UserContestScoreSummaryWithUserInfo])
   async getContestScoreSummaries(
-    @Args('take', { type: () => Int, defaultValue: 10 }) take: number,
-    @Args('contestId', { type: () => Int }) contestId: number,
-    @Args('cursor', { type: () => Int, nullable: true }) cursor: number | null
+    @Args('contestId', { type: () => Int, nullable: false }, IDValidationPipe)
+    contestId: number,
+    @Args('take', { type: () => Int, defaultValue: 10 })
+    take: number,
+    @Args('cursor', { type: () => Int, nullable: true }, CursorValidationPipe)
+    cursor: number | null,
+    @Args('searchingName', { type: () => String, nullable: true })
+    searchingName?: string
   ) {
-    try {
-      return await this.contestService.getContestScoreSummaries(
-        take,
-        contestId,
-        cursor
-      )
-    } catch (error) {
-      if (error instanceof EntityNotExistException) {
-        throw error.convert2HTTPException()
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.contestService.getContestScoreSummaries(
+      contestId,
+      take,
+      cursor,
+      searchingName
+    )
   }
 
   @Query(() => ContestsGroupedByStatus)
   async getContestsByProblemId(
     @Args('problemId', { type: () => Int }) problemId: number
   ) {
-    try {
-      return await this.contestService.getContestsByProblemId(problemId)
-    } catch (error) {
-      if (error instanceof EntityNotExistException) {
-        throw error.convert2HTTPException()
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.contestService.getContestsByProblemId(problemId)
   }
 }