-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(be): admin problem and submission exception handling #2130
Closed
mnseok
wants to merge
85
commits into
main
from
t922-refactore-admin-problem-and-submission-exception-handling
Closed
refactor(be): admin problem and submission exception handling #2130
mnseok
wants to merge
85
commits into
main
from
t922-refactore-admin-problem-and-submission-exception-handling
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jaehyeon1020
changed the title
refactore(be): admin problem and submission exception handling
refactor(be): admin problem and submission exception handling
Oct 3, 2024
Jaehyeon1020
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try - catch에서 InternalServerErrorExceptino으로 처리하신 부분이 많이 보이는데, 원인을 파악할 수 없는 에러는 기존의 기본 Exception Filter에서 자동으로 InternalServerError로 처리됩니다.
불필요하게 2중으로 처리되고 있는 부분 같아서 이 부분들은 모두 삭제해주셔도 괜찮을 것 같아요!
* fix(fe): prevent horizontal scrollbar from appearing * chore: fix broken cover ui * chore: trigger github action
* feat(fe): add create problem alert dialog component * feat(fe): add create problem form component * feat(fe): add confirm navigation component * chore(fe): add use client directive * refactor(fe): refactor admin problem create page * chore: use not operator * chore: trigger github action * chore(fe): use private folder
* chore(fe): block testcase and limit edit when submission exist * chore(fe): change blockEdit as optional property
* feat(be): implement search in contest overall apis * docs(be): add description about searching name * chore(be): add exception handling logic * docs(be): change searching-name condition
* refactor(fe): add hide spin button util style, delete hide scroll bar plugin * fix(fe): fix pnpm lock file * chore(fe): add import type declaration
* feat(be): handle prisma exception in global exception filter * chore(be): rename function * docs(be): add jsdoc * feat(be): add extra information
…2118) * refactor(be): improve client submission module error handling logic * chore(be): revert deleted comments * chore(be): change submission test code followed by refactor
* refactor(be): improve client problem error handling * refactor(be): just throw error in problem controller * refactor(be): change problem test code followed by refactor * chore(be): revert deleted eslint comment
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix(fe): refactor save * fix(fe): refactor settings * chore(fe): change import path name * fix(fe): change navigation * chore(fe): fix typo * chore(fe): delete import react * chore(fe): delete import react * chore(fe): use cn
* fix(deps): update all non-major dependencies * chore(deps): add rxjs, apply typescript change * chore(deps): remove typescript upgrade dep * chore(deps): remove not needed dependency * chore: typescript downgrade * chore(deps): downgrade typescript to 5.5.4 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jimin Ha <jimin9038@g.skku.edu>
…CS and S3 (#2138) * feat(infra): created gateway vpc endpoint for communication between ECS and S3 Created gateway vpc endpoint intended to replace NAT instance for communication between ECS and S3. For testing this features is working, erase S3 bucket policy that allows NAT instance's public ip. If the communication between ECS and S3 still works, this gateway vpc endpoint is deemed working properly. Also, moved the content of gateway_vpc_endpoint_to_s3 in /network directory to s3_gateway_vpc_endpoint in the /storage directory (unlike in PR #2122). * feat(infra): created gateway vpc endpoint for communication between ECS and S3 * feat(infra): created gateway vpc endpoint for communication between ECS and S3
…CS and S3 (#2168) * feat(infra): created gateway vpc endpoint for communication between ECS and S3 Created gateway vpc endpoint intended to replace NAT instance for communication between ECS and S3. For testing this features is working, erase S3 bucket policy that allows NAT instance's public ip. If the communication between ECS and S3 still works, this gateway vpc endpoint is deemed working properly. Also, moved the content of gateway_vpc_endpoint_to_s3 in /network directory to s3_gateway_vpc_endpoint in the /storage directory (unlike in PR #2122). * feat(infra): created gateway vpc endpoint for communication between ECS and S3 * feat(infra): created gateway vpc endpoint for communication between ECS and S3
…ensure latest minor updates (#2169) * fix(infra): set portgres version to 14 to avoid downgrade errors and ensure latest minor updates * fix(infra): set portgres version to 14 to avoid downgrade errors and ensure latest minor updates
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix(fe): edit submission take * fix(fe): fix participant submission take number
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
#2176) * refactor(fe): refactor admin user table * refactor(fe): refactor admin problem table * refactor(fe): refactor admin contest table * refactor(fe): refactor contest problem table and import problem table * chore(fe): fix admin page layout * fix(fe): reset page index when the filter is changed * chore(fe): add error toast message * chore(fe): separate component file * fix(fe): force to trigger sorting fn when the row selection is changed
#2177) * refactor(fe): refactor participant table * refactor(fe): refactor contest submission table * refactor(fe): refactor user score table and user submission table * chore(fe): fix width style * chore(fe): fix fallback ui * chore(fe): remove unnecessary components
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(fe): use coolify.codedang.com as stage.codedang.com * fix(fe): remove force dynamic in main page * chore(fe): suppress exhausted deps since we use useinterval * chore(fe): add eslint-config-next as root devDependencies * chore(fe): exclude next.config.js from linting
* chore(fe): classify client with main and code-editor folder * refactor(fe): add handler folder * refactor(fe): add admin/_libs folder * chore(fe): remove sentry example page * refactor(fe): change dynamic route name * chore(fe): remove unnecessary folder * refactor(fe): move dataIfError.ts file to _libs folder * chore: trigger build * refactor(fe): move utils file to _libs folder * refactor(fe): add _libs folder in the admin folder * chore(fe): move utils file to the _libs folder * refactor(fe): refactor styles.css file with tailwind css * chore(fe): fix import path --------- Co-authored-by: b0xercat <seojin3154@naver.com>
* refactor(be): adm user cli auth exception refator * refactor(be): admin user client auth refactoring * refactor(be): pr review correction * refactor(be): refactor admin user cli auth * refactor(be): remove unused try-catch * refactor(be): refactor auth module exception handling logic --------- Co-authored-by: Jaehyeon Kim <kjhkk1020@naver.com> Co-authored-by: Jaehyeon Kim <65964601+Jaehyeon1020@users.noreply.github.com>
* fix(be): change testKey for race condition * fix(be): update cache set and get logic * fix(be): update handleRunMessage to apply changed cache * fix(be): ensure consistency with repo * fix(be): print output when compile error
* refactor(re): refactor public folde * Optimised images with calibre/image-actions * fix(fe): fix directory * fix(fe): fix file name --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix(fe): fix params prop type * chore(fe): fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
에러 핸들링 부분을 resolver에서 service 부분으로 옮겼습니다.
Before submitting the PR, please make sure you do the following
fixes #123
).