refactor(be): admin problem and submission exception handling

apps/backend/apps/admin/src/problem/problem.resolver.ts

@@ -1,12 +1,4 @@
-import {
-  InternalServerErrorException,
-  Logger,
-  NotFoundException,
-  ParseArrayPipe,
-  UnprocessableEntityException,
-  UsePipes,
-  ValidationPipe
-} from '@nestjs/common'
+import { ParseArrayPipe, UsePipes, ValidationPipe } from '@nestjs/common'
 import {
   Args,
   Context,
@@ -24,15 +16,8 @@ import {
   ProblemTestcase,
   WorkbookProblem
 } from '@generated'
-import { Prisma } from '@prisma/client'
-import { PrismaClientKnownRequestError } from '@prisma/client/runtime/library'
 import { AuthenticatedRequest } from '@libs/auth'
 import { OPEN_SPACE_ID } from '@libs/constants'
-import {
-  ConflictFoundException,
-  ForbiddenAccessException,
-  UnprocessableDataException
-} from '@libs/exception'
 import { CursorValidationPipe, GroupIDPipe, RequiredIntPipe } from '@libs/pipe'
 import { ImageSource } from './model/image.output'
 import {
@@ -46,8 +31,6 @@ import { ProblemService } from './problem.service'
 
 @Resolver(() => ProblemWithIsVisible)
 export class ProblemResolver {
-  private readonly logger = new Logger(ProblemResolver.name)
-
   constructor(private readonly problemService: ProblemService) {}
 
   @Mutation(() => ProblemWithIsVisible)
@@ -61,24 +44,7 @@ export class ProblemResolver {
     groupId: number,
     @Args('input') input: CreateProblemInput
   ) {
-    try {
-      return await this.problemService.createProblem(
-        input,
-        req.user.id,
-        groupId
-      )
-    } catch (error) {
-      if (error instanceof UnprocessableDataException) {
-        throw error.convert2HTTPException()
-      } else if (
-        error instanceof Prisma.PrismaClientKnownRequestError &&
-        error.code === 'P2003'
-      ) {
-        throw new UnprocessableEntityException(error.message)
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.problemService.createProblem(input, req.user.id, groupId)
   }
 
   @Mutation(() => [ProblemWithIsVisible])
@@ -93,56 +59,23 @@ export class ProblemResolver {
     groupId: number,
     @Args('input') input: UploadFileInput
   ) {
-    try {
-      return await this.problemService.uploadProblems(
-        input,
-        req.user.id,
-        groupId
-      )
-    } catch (error) {
-      if (error instanceof UnprocessableDataException) {
-        throw error.convert2HTTPException()
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.problemService.uploadProblems(input, req.user.id, groupId)
   }
 
   @Mutation(() => ImageSource)
   async uploadImage(
     @Args('input') input: UploadFileInput,
     @Context('req') req: AuthenticatedRequest
   ) {
-    try {
-      return await this.problemService.uploadImage(input, req.user.id)
-    } catch (error) {
-      if (error instanceof UnprocessableDataException) {
-        throw error.convert2HTTPException()
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.problemService.uploadImage(input, req.user.id)
   }
 
   @Mutation(() => Image)
   async deleteImage(
     @Args('filename') filename: string,
     @Context('req') req: AuthenticatedRequest
   ) {
-    try {
-      return await this.problemService.deleteImage(filename, req.user.id)
-    } catch (error) {
-      if (error instanceof UnprocessableDataException) {
-        throw error.convert2HTTPException()
-      } else if (
-        error instanceof PrismaClientKnownRequestError &&
-        error.code == 'P2025'
-      ) {
-        throw new NotFoundException(error.message)
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.problemService.deleteImage(filename, req.user.id)
   }
 
   @Query(() => [ProblemWithIsVisible])
@@ -171,38 +104,17 @@ export class ProblemResolver {
     groupId: number,
     @Args('id', { type: () => Int }, new RequiredIntPipe('id')) id: number
   ) {
-    try {
-      return await this.problemService.getProblem(id, groupId)
-    } catch (error) {
-      if (
-        error instanceof Prisma.PrismaClientKnownRequestError &&
-        error.name == 'NotFoundError'
-      ) {
-        throw new NotFoundException(error.message)
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.problemService.getProblem(id, groupId)
   }
 
   @ResolveField('tag', () => [ProblemTag])
   async getProblemTags(@Parent() problem: ProblemWithIsVisible) {
-    try {
-      return await this.problemService.getProblemTags(problem.id)
-    } catch (error) {
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.problemService.getProblemTags(problem.id)
   }
 
   @ResolveField('testcase', () => [ProblemTestcase])
   async getProblemTestCases(@Parent() problem: ProblemWithIsVisible) {
-    try {
-      return await this.problemService.getProblemTestcases(problem.id)
-    } catch (error) {
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.problemService.getProblemTestcases(problem.id)
   }
 
   @Mutation(() => ProblemWithIsVisible)
@@ -215,24 +127,7 @@ export class ProblemResolver {
     groupId: number,
     @Args('input') input: UpdateProblemInput
   ) {
-    try {
-      return await this.problemService.updateProblem(input, groupId)
-    } catch (error) {
-      if (
-        error instanceof UnprocessableDataException ||
-        error instanceof ConflictFoundException
-      ) {
-        throw error.convert2HTTPException()
-      } else if (error instanceof Prisma.PrismaClientKnownRequestError) {
-        if (error.name == 'NotFoundError') {
-          throw new NotFoundException(error.message)
-        } else if (error.code === 'P2003') {
-          throw new UnprocessableEntityException(error.message)
-        }
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.problemService.updateProblem(input, groupId)
   }
 
   @Mutation(() => ProblemWithIsVisible)
@@ -245,25 +140,12 @@ export class ProblemResolver {
     groupId: number,
     @Args('id', { type: () => Int }, new RequiredIntPipe('id')) id: number
   ) {
-    try {
-      return await this.problemService.deleteProblem(id, groupId)
-    } catch (error) {
-      if (
-        error instanceof Prisma.PrismaClientKnownRequestError &&
-        error.name == 'NotFoundError'
-      ) {
-        throw new NotFoundException(error.message)
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.problemService.deleteProblem(id, groupId)
   }
 }
 
 @Resolver(() => ContestProblem)
 export class ContestProblemResolver {
-  private readonly logger = new Logger(ProblemResolver.name)
-
   constructor(private readonly problemService: ProblemService) {}
 
   @Query(() => [ContestProblem], { name: 'getContestProblems' })
@@ -277,20 +159,7 @@ export class ContestProblemResolver {
     @Args('contestId', { type: () => Int }, new RequiredIntPipe('contestId'))
     contestId: number
   ) {
-    try {
-      return await this.problemService.getContestProblems(groupId, contestId)
-    } catch (error) {
-      if (
-        error instanceof UnprocessableDataException ||
-        error instanceof ForbiddenAccessException
-      ) {
-        throw error.convert2HTTPException()
-      } else if (error.code == 'P2025') {
-        throw new NotFoundException(error.message)
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException(error.message)
-    }
+    return await this.problemService.getContestProblems(groupId, contestId)
   }
 
   @Mutation(() => [ContestProblem])
@@ -305,41 +174,21 @@ export class ContestProblemResolver {
     contestId: number,
     @Args('orders', { type: () => [Int] }, ParseArrayPipe) orders: number[]
   ) {
-    try {
-      return await this.problemService.updateContestProblemsOrder(
-        groupId,
-        contestId,
-        orders
-      )
-    } catch (error) {
-      if (
-        error instanceof UnprocessableDataException ||
-        error instanceof ForbiddenAccessException
-      ) {
-        throw error.convert2HTTPException()
-      } else if (error.code == 'P2025') {
-        throw new NotFoundException(error.message)
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException(error.message)
-    }
+    return await this.problemService.updateContestProblemsOrder(
+      groupId,
+      contestId,
+      orders
+    )
   }
 
   @ResolveField('problem', () => ProblemWithIsVisible)
   async getProblem(@Parent() contestProblem: ContestProblem) {
-    try {
-      return await this.problemService.getProblemById(contestProblem.problemId)
-    } catch (error) {
-      this.logger.error(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.problemService.getProblemById(contestProblem.problemId)
   }
 }
 
 @Resolver(() => WorkbookProblem)
 export class WorkbookProblemResolver {
-  private readonly logger = new Logger(ProblemResolver.name)
-
   constructor(private readonly problemService: ProblemService) {}
 
   @Query(() => [WorkbookProblem], { name: 'getWorkbookProblems' })
@@ -352,20 +201,7 @@ export class WorkbookProblemResolver {
     groupId: number,
     @Args('workbookId', { type: () => Int }) workbookId: number
   ) {
-    try {
-      return await this.problemService.getWorkbookProblems(groupId, workbookId)
-    } catch (error) {
-      if (
-        error instanceof UnprocessableDataException ||
-        error instanceof ForbiddenAccessException
-      ) {
-        throw error.convert2HTTPException()
-      } else if (error.code == 'P2025') {
-        throw new NotFoundException(error.message)
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException(error.message)
-    }
+    return await this.problemService.getWorkbookProblems(groupId, workbookId)
   }
 
   @Mutation(() => [WorkbookProblem])
@@ -380,33 +216,15 @@ export class WorkbookProblemResolver {
     // orders는 항상 workbookId에 해당하는 workbookProblems들이 모두 딸려 온다.
     @Args('orders', { type: () => [Int] }, ParseArrayPipe) orders: number[]
   ) {
-    try {
-      return await this.problemService.updateWorkbookProblemsOrder(
-        groupId,
-        workbookId,
-        orders
-      )
-    } catch (error) {
-      if (
-        error instanceof UnprocessableDataException ||
-        error instanceof ForbiddenAccessException
-      ) {
-        throw error.convert2HTTPException()
-      } else if (error.code == 'P2025') {
-        throw new NotFoundException(error.message)
-      }
-      this.logger.error(error)
-      throw new InternalServerErrorException(error.message)
-    }
+    return await this.problemService.updateWorkbookProblemsOrder(
+      groupId,
+      workbookId,
+      orders
+    )
   }
 
   @ResolveField('problem', () => ProblemWithIsVisible)
   async getProblem(@Parent() workbookProblem: WorkbookProblem) {
-    try {
-      return await this.problemService.getProblemById(workbookProblem.problemId)
-    } catch (error) {
-      console.log(error)
-      throw new InternalServerErrorException()
-    }
+    return await this.problemService.getProblemById(workbookProblem.problemId)
   }
 }