Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-vitess-r15.0.5: backport v20 vtgate syscall/topo-call optimizations #227

Merged
merged 7 commits into from
Mar 15, 2024
Merged

slack-vitess-r15.0.5: backport v20 vtgate syscall/topo-call optimizations #227

merged 7 commits into from
Mar 15, 2024

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Feb 28, 2024 •
edited
Loading

Description

This PR backports several v20 PRs that address runtime crashes of vtgate due to too many (10k+) concurrent syscalls

PRs:

  1. Update MySQL apt package and GPG signature vitessio/vitess#14785 (already merged)
  2. Load --grpc_auth_static_client_creds file once vitessio/vitess#15030
  3. Limit concurrent creation of healthcheck gRPC connections vitessio/vitess#15053
  4. Filter by keyspace earlier in tabletgateways WaitForTablets(...) vitessio/vitess#15347

Related Issue(s)

  1. Feature Request: cache static auth creds in go/vt/grpcclient vitessio/vitess#15031

PRs above

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt
Load --grpc_auth_static_client_creds file once (vitessio#15030)
ade2b26 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Filter by keyspace earlier in tabletgateways WaitForTablets(...) (v…
44864bf 
…itessio#15347)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Limit concurrent creation of healthcheck gRPC connections (vitessio#1…
fc17ce9 
…5053)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
go mod tidy
0da45ba 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@github-actions github-actions bot added this to the v15.0.5 milestone Feb 28, 2024
@mattlord @timvaillancourt
Update MySQL apt package and GPG signature (vitessio#14785)
24da72f 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@salesforce-cla Salesforce CLA
Copy link

Thanks for the contribution! Before we can merge this, we need @mattlord to sign the Salesforce Inc. Contributor License Agreement.

@timvaillancourt timvaillancourt added v15 upstream-backport An upstream backport labels Mar 14, 2024
@timvaillancourt
remove unrelated workflow files from v20
bb389f6 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt marked this pull request as ready for review March 14, 2024 22:10
@timvaillancourt timvaillancourt requested a review from a team as a code owner March 14, 2024 22:10
@timvaillancourt timvaillancourt changed the title slack-vitess-r15.0.5: backport v20 vtgate syscall fixes slack-vitess-r15.0.5: backport v20 vtgate syscall/topo-call optimizations Mar 15, 2024
@timvaillancourt timvaillancourt merged commit 355006a into slack-vitess-r15.0.5 Mar 15, 2024
194 of 195 checks passed
@timvaillancourt timvaillancourt deleted the bp-vtgate-sycalls-slack-vitess-r15.0.5 branch March 15, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjinx tanjinx tanjinx approved these changes

Assignees
No one assigned
Labels
cla:missing upstream-backport An upstream backport v15 v20-backport
Projects
None yet
Milestone
v15.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@timvaillancourt @tanjinx @mattlord