CCIP-4703: Adding check for ChainFeeUpdates field #410
+233
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-gopalswami
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xAustinWang
b-gopalswami
commented
Dec 31, 2024
| return fmt.Errorf("nil or non-positive %s", "execution fee price") | ||
| } | ||
|
|
||
| if update.ChainFee.DataAvFeePriceUSD == nil || update.ChainFee.DataAvFeePriceUSD.Cmp(zero) < 0 { |
There was a problem hiding this comment.
I believe this DataAvFeePriceUSD might be zero for EVM chain and shouldn't be zero for L2 chains. Is that right? If at all we can know the given chain is L2, then we can add additional check here.
makramkd
reviewed
Jan 6, 2025
|
makramkd
reviewed
Jan 7, 2025
| for _, token := range obs.NativeTokenPrices { | ||
| if token.Int == nil || token.Int.Cmp(zero) <= 0 { | ||
| return fmt.Errorf("nil or non-positive %s", "execution fee") | ||
| func (p *processor) ValidateObservedChains( |
There was a problem hiding this comment.
This function shouldn't be public since it'll only get called from the chainfee processor
asoliman92
reviewed
Jan 8, 2025
| if err != nil { | ||
| return fmt.Errorf("failed to get supported chains: %w", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
We'll need to add extra checks here to make sure that all keys in all maps are exactly the same, otherwise we can end up with same lengths but for different chains on different maps.
asoliman92
reviewed
Jan 8, 2025
|
|
||
| for _, token := range obs.NativeTokenPrices { | ||
| if token.Int == nil || token.Int.Cmp(zero) <= 0 { | ||
| return fmt.Errorf("nil or non-positive %s", "execution fee") | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Add validation for timpestamps making sure they're not zero or more than current utc timestamp.
asoliman92
requested changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing check for ChainFeeUpdates field.
The review comment asks to check for non-positive value on DataAvailableFee field but I believe that can be zero when it is EVM chain so keeping that check for only non-negative values. Only if it is L2 chain, it should be non-positive.