Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP-4703: Adding check for ChainFeeUpdates field #410
CCIP-4703: Adding check for ChainFeeUpdates field #410
Changes from 1 commit
4addc48
a28b6b7
5bcb9b8
5146533
b36980f
7cb45b1
22de002
eaf6b01
adf719d
053c08f
8a43f25
941d029
0df3535
a0ac3ea
9cb84c1
960a2e8
a3acd67
b9a20ab
deac5db
cb2ed66
71c5c6a
f1b4bb2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 12 in commit/chainfee/validate_observation.go
GitHub Actions / build-lint-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this DataAvFeePriceUSD might be zero for EVM chain and shouldn't be zero for L2 chains. Is that right? If at all we can know the given chain is L2, then we can add additional check here.