Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Chain Reader to Contract Reader in places that import from common #848

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Rename Chain Reader to Contract Reader in places that import from common #848

merged 4 commits into from
Sep 10, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Sep 10, 2024 •
edited
Loading

core ref: 361e2f85fc8124b2ceca442f5ac6377b3576c649

@ilija42 ilija42 requested review from a team as code owners September 10, 2024 13:01
This was referenced Sep 10, 2024
Merged
Merged
Merged
Merged
Merged
Farber98
Farber98 reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@Farber98 Farber98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you'll need to bump chainlink-feeds, chainlink-cosmos, chainlink-starknet and core for the CI to pass

jmank88
jmank88 previously approved these changes Sep 10, 2024
View reviewed changes
@ilija42 ilija42 requested review from Farber98 and jmank88 September 10, 2024 16:02
@aalu1418 aalu1418 enabled auto-merge (squash) September 10, 2024 16:06
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@aalu1418 aalu1418 merged commit a7050b5 into develop Sep 10, 2024
33 checks passed
@aalu1418 aalu1418 deleted the BCF-3380-rename-CR branch September 10, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@jmank88 jmank88 jmank88 approved these changes

@Farber98 Farber98 Awaiting requested review from Farber98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilija42 @jmank88 @Farber98 @aalu1418