Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCF-3380 Rename ChainReader imports to ContractReader to match common #14383

Merged
merged 7 commits into from
Sep 10, 2024
Merged

BCF-3380 Rename ChainReader imports to ContractReader to match common #14383

merged 7 commits into from
Sep 10, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Sep 10, 2024 •
edited
Loading

@ilija42 ilija42 requested review from a team as code owners September 10, 2024 13:22
@ilija42 ilija42 requested review from Atrax1 and removed request for a team September 10, 2024 13:22
@ilija42 ilija42 mentioned this pull request Sep 10, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

This was referenced Sep 10, 2024
Merged
Merged
Merged
Farber98
Farber98 reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@Farber98 Farber98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to run make generate to pass CI Core / Clean Go Tidy & Generate (pull_request) and fix go.md

@ilija42 ilija42 requested a review from Farber98 September 10, 2024 17:19
silaslenihan
silaslenihan approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@silaslenihan silaslenihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than CI failures

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ilija42 ilija42 requested review from a team and jmank88 September 10, 2024 17:54
@ilija42 ilija42 enabled auto-merge September 10, 2024 17:54
Farber98
Farber98 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@Farber98 Farber98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ilija42 ilija42 added this pull request to the merge queue Sep 10, 2024
Merged via the queue into develop with commit e2522fd Sep 10, 2024
135 of 137 checks passed
@ilija42 ilija42 deleted the BCF-3380-rename-CR branch September 10, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Farber98 Farber98 Farber98 approved these changes

@silaslenihan silaslenihan silaslenihan approved these changes

@Atrax1 Atrax1 Awaiting requested review from Atrax1 Atrax1 is a code owner automatically assigned from smartcontractkit/foundations

@jmank88 jmank88 Awaiting requested review from jmank88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilija42 @silaslenihan @Farber98