remove gotestloghelper from core tests #15395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
… -json flag, remove gotestloghelper
Tofel
changed the title
jmank88
reviewed
Nov 25, 2024
jmank88
reviewed
Nov 25, 2024
jmank88
reviewed
Nov 25, 2024
jmank88
reviewed
Nov 25, 2024
erikburt
reviewed
Nov 25, 2024
erikburt
reviewed
Nov 25, 2024
| @@ -3,26 +3,18 @@ set -o pipefail | |||
| set +e | |||
|
|
|||
| SCRIPT_PATH=`dirname "$0"`; SCRIPT_PATH=`eval "cd \"$SCRIPT_PATH\" && pwd"` | |||
| OUTPUT_FILE="../output.txt" | |||
| USE_TEE="${USE_TEE:-true}" | |||
| OUTPUT_FILE=${OUTPUT_FILE:-"./output.txt"} | |||
There was a problem hiding this comment.
This pathing has changed a bit, it used to be ‘../output.txt’ because this test cds into the deployment directory.
I think we need to keep it in the parent directory otherwise the artifact upload will not be able to find the output.
There was a problem hiding this comment.
good catch, @erikburt!
jmank88
reviewed
Nov 25, 2024
erikburt
previously approved these changes
Nov 25, 2024
jmank88
reviewed
Nov 25, 2024
tools/bin/go_core_race_tests
Outdated
There was a problem hiding this comment.
Lines 10 and 12 are both identical:
GORACE="log_path=$PWD/race" go test -race -shuffle on -timeout "$TIMEOUT" -count "$COUNT" $1 | cat > $OUTPUT_FILE
erikburt
approved these changes
Nov 25, 2024
jmank88
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.