CCIP-4359 fee quoter supports interface for keystone #15448

0xsuryansh · 2024-11-28T11:37:37Z

Keystone Forwarder checks for the receiver to support IReceiver interface using ERC165 supportsInterface

This PR :

Enforced IReceiver implementations to implement supportsInterface

…eeQuoter.sol

…Keystone

…eeQuoter.sol

github-actions · 2024-11-28T11:39:19Z

Static analysis results are available

Hey @0xsuryansh, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

github-actions · 2024-11-28T11:58:28Z

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

…face_for_Keystone' into CCIP-4359_FeeQuoter_supportsInterface_for_Keystone

…_Keystone # Conflicts: # contracts/gas-snapshots/ccip.gas-snapshot # core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt

github-actions · 2024-11-28T13:32:09Z

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/tender-lemons-punch.md

This PR has been linked to Solidity Review Jira issue: CCIP-3966

…_Keystone

…face_for_Keystone' into CCIP-4359_FeeQuoter_supportsInterface_for_Keystone

contracts/src/v0.8/ccip/FeeQuoter.sol

contracts/src/v0.8/keystone/interfaces/IReceiver.sol

RensR

can you add a test that actually uses the keystone contract to call into the feeQuoter

RensR · 2024-12-02T08:55:53Z

contracts/src/v0.8/ccip/FeeQuoter.sol

@@ -3,6 +3,7 @@ pragma solidity 0.8.24;

 import {IReceiver} from "../keystone/interfaces/IReceiver.sol";
 import {ITypeAndVersion} from "../shared/interfaces/ITypeAndVersion.sol";
+


nit: remove newline

…_Keystone # Conflicts: # contracts/gas-snapshots/ccip.gas-snapshot

This reverts commit 4a62610.

…_Keystone

…r CCIP" This reverts commit 5a0d650.

…_Keystone

…erage for CCIP"" This reverts commit 2c86461.

0xsuryansh and others added 4 commits November 28, 2024 16:24

fix: enforce supports interface from IReceiver.sol and impliment in F…

bd17333

…eeQuoter.sol

Merge branch 'develop' into CIP-4359_FeeQuoter_supportsInterface_for_…

5f6bb9c

…Keystone

fix: enforce supports interface from IReceiver.sol and impliment in F…

4455a29

…eeQuoter.sol

Merge 4455a29 into 936d9fd

a745e3c

Update gethwrappers

b965934

0xsuryansh and others added 5 commits November 28, 2024 18:55

CCIP-4359 changeset + minor fixes and wrappers

85edd82

Merge remote-tracking branch 'origin/CIP-4359_FeeQuoter_supportsInter…

0821dc6

…face_for_Keystone' into CCIP-4359_FeeQuoter_supportsInterface_for_Keystone

Merge branch 'develop' into CCIP-4359_FeeQuoter_supportsInterface_for…

9a96e9f

…_Keystone # Conflicts: # contracts/gas-snapshots/ccip.gas-snapshot # core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt

snapshot update

6877c43

[Bot] Update changeset file with jira issues

47f7867

0xsuryansh marked this pull request as ready for review November 28, 2024 13:36

0xsuryansh requested review from a team as code owners November 28, 2024 13:36

DeividasK previously approved these changes Nov 28, 2024

View reviewed changes

0xsuryansh added 3 commits November 29, 2024 15:52

Merge branch 'develop' into CCIP-4359_FeeQuoter_supportsInterface_for…

d017f2e

…_Keystone

Merge remote-tracking branch 'origin/CIP-4359_FeeQuoter_supportsInter…

60221e9

…face_for_Keystone' into CCIP-4359_FeeQuoter_supportsInterface_for_Keystone

lint fix

740ec59

0xsuryansh dismissed DeividasK’s stale review via 740ec59 November 29, 2024 10:32

0xsuryansh requested a review from DeividasK November 29, 2024 10:33

RensR reviewed Nov 29, 2024

View reviewed changes

contracts/src/v0.8/ccip/FeeQuoter.sol Outdated Show resolved Hide resolved

contracts/src/v0.8/ccip/FeeQuoter.sol Show resolved Hide resolved

contracts/src/v0.8/keystone/interfaces/IReceiver.sol Show resolved Hide resolved

0xsuryansh added 7 commits November 29, 2024 16:09

chore: import arrangement and additional comments

b230194

fix : comment in IReceiver

0dc9bfe

fix : comment in KeystoneFeedsPermissionHandler

1269810

fmt

95c4eb0

add fee_quoter_interface

b20c581

add fee_quoter_interface

9c5ea7f

remove incorrectly added mock interface

3c362b6

RensR reviewed Dec 2, 2024

View reviewed changes

added test with Keystone Forwarder

8b0b2f8

0xsuryansh dismissed DeividasK’s stale review via 8b0b2f8 December 2, 2024 13:28

update cod cov ignore for ccip

4a62610

0xsuryansh requested review from a team as code owners December 2, 2024 15:13

0xsuryansh added 3 commits December 2, 2024 20:56

cleanup: removed newline

e4da55e

Merge branch 'develop' into CCIP-4359_FeeQuoter_supportsInterface_for…

9ee9f9b

…_Keystone # Conflicts: # contracts/gas-snapshots/ccip.gas-snapshot

update coverage

c8e0815

0xsuryansh requested review from RensR and DeividasK December 2, 2024 15:57

0xsuryansh added 9 commits December 3, 2024 17:07

Revert "update cod cov ignore for ccip"

58e30f6

This reverts commit 4a62610.

update lcov_prine to exclude keystone contract in coverage for CCIP

5a0d650

Merge branch 'develop' into CCIP-4359_FeeQuoter_supportsInterface_for…

15de6a4

…_Keystone

Revert "update lcov_prine to exclude keystone contract in coverage fo…

2c86461

…r CCIP" This reverts commit 5a0d650.

remove keystone test setup dependency

d698dc5

chore: update test name according to style guide

24e7b18

Merge branch 'develop' into CCIP-4359_FeeQuoter_supportsInterface_for…

39a8e89

…_Keystone

update snapshot

c083903

Revert "Revert "update lcov_prine to exclude keystone contract in cov…

4ff5f2b

…erage for CCIP"" This reverts commit 2c86461.

RensR approved these changes Dec 4, 2024

View reviewed changes

kalverra approved these changes Dec 4, 2024

View reviewed changes

DeividasK approved these changes Dec 4, 2024

View reviewed changes

0xsuryansh added this pull request to the merge queue Dec 4, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024

0xsuryansh added this pull request to the merge queue Dec 4, 2024

Merged via the queue into develop with commit c1ee7ab Dec 4, 2024
202 of 203 checks passed

0xsuryansh deleted the CIP-4359_FeeQuoter_supportsInterface_for_Keystone branch December 4, 2024 17:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CCIP-4359 fee quoter supports interface for keystone #15448

CCIP-4359 fee quoter supports interface for keystone #15448

0xsuryansh commented Nov 28, 2024

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

RensR left a comment

RensR Dec 2, 2024

0xsuryansh Dec 2, 2024

		@@ -3,6 +3,7 @@ pragma solidity 0.8.24;

		import {IReceiver} from "../keystone/interfaces/IReceiver.sol";
		import {ITypeAndVersion} from "../shared/interfaces/ITypeAndVersion.sol";

CCIP-4359 fee quoter supports interface for keystone #15448

CCIP-4359 fee quoter supports interface for keystone #15448

Conversation

0xsuryansh commented Nov 28, 2024

github-actions bot commented Nov 28, 2024 • edited Loading

Static analysis results are available

github-actions bot commented Nov 28, 2024 • edited Loading

AER Report: CI Core ran successfully ✅

AER Report: Operator UI CI ran successfully ✅

github-actions bot commented Nov 28, 2024 • edited Loading

Solidity Review Jira issue

RensR left a comment

Choose a reason for hiding this comment

RensR Dec 2, 2024

Choose a reason for hiding this comment

0xsuryansh Dec 2, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading