Fix: Protean + Neutralizing Gas interaction

[andrebastosdias]

"If a Protean/Libero Pokemon activates its ability once, switches out, then switches back in while a Neutralizing Gas Pokemon is active, Protean/Libero won't activate even after Neutralizing Gas stops working. This is because Protean/Libero use an event callback to reset the flag, which Neutralizing Gas suppresses."

[andrebastosdias]

Is this the best or standard way to check if this is the Pokémon switching in?

[urkerab]

I'm not sure what you're asking but pokemon will always be the Pokémon switching in.

[andrebastosdias]

Correct me if I'm wrong, but I'm pretty sure that when a switch occurs, onAnySwitchIn is called for every active Pokémon and pokemon does not refer to the Pokémon switching in.

I wanted to know if this.event.target is the best way to access the switching-in Pokémon or if there is another variable that could be used.

[urkerab]

onAnySwitchIn is called for every active effect with that handler, but pokemon is always the Pokémon switching in; if you wanted to know which Pokémon has Neutralizing Gas, you would need to look at this.effectState.target.

[andrebastosdias]

Oh, I'm dumb. onAnySwitchIn is called for every active Pokémon, but only the one with Neutralizing Gas triggers this specific function. Thanks!

[DaWoblefet]

This bug would also apply for Abilities like Embody Aspect, since they also only activate once per time out on the field.

[DaWoblefet]

I feel like this should not be tied to Neutralizing Gas specifically. I'm sure there's some Baton Pass Gastro Acid shenanigans you can do to cause the same thing to happen. Wouldn't it be better to just delete the effectState for Protean/Libero/Embody Aspect when the Pokemon leaves the field / loses the Ability (like how Slow Start does it)? I don't see why we're removing it on switchin in the first place.

[DaWoblefet]

You can't merge the effectStates for Protean and Libero either, I don't think. If you change type with Libero, then Skill Swap it Protean, you can still change type with the newly acquired Protean. In general, you can Skill Swap around Libero / Protean and change your type again each time, too (e.g. use Bite with Libero -> change to Dark-type; be given Protean; use Tackle with Protean -> change to Normal-type; be given Libero; use Bite with Libero -> change to Dark-type). It should only hold the effectState for as long as the Pokemon has the Ability.

[andrebastosdias]

onSwitchOut wouldn't run, unless it's hard-coded in another place.

The ability states are being reset.

pokemon-showdown/data/moves.ts

Lines 17214 to 17223 in c8bc6be

	this.singleEvent('End', sourceAbility, source.abilityState, source);
	this.singleEvent('End', targetAbility, target.abilityState, target);
	source.ability = targetAbility.id;
	target.ability = sourceAbility.id;
	source.abilityState = {id: this.toID(source.ability), target: source};
	target.abilityState = {id: this.toID(target.ability), target: target};
	source.volatileStaleness = undefined;
	if (!target.isAlly(source)) target.volatileStaleness = 'external';
	this.singleEvent('Start', targetAbility, source.abilityState, source);
	this.singleEvent('Start', sourceAbility, target.abilityState, target);

[DaWoblefet]

Skill Swap Libero -> Skill Swap Libero works, yeah. The effectState is tied to the particular instance of the Ability, so to speak.

As another example, using Libero Bite -> change to Dark-type, then switch in Neutralizing Gas and switch it out, then using Shore Up will not change to Ground-type.

[andrebastosdias]

We could add an ability check with eventid !== 'End' && effect.effectType === 'Ability' && (target instanceof Pokemon) && target.ignoringAbility(), but that approach seems quite inelegant.

Perhaps we could use previouslySwitchedIn.

[DaWoblefet]

The ability states are being reset.

Does just using abilityState work for Protean / Libero / Embody Aspect work then?

[DaWoblefet]

Thanks andrebastosdias!