Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Implement low power mode for cmis host management #17159

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

Junchao-Mellanox
Copy link
Collaborator

@Junchao-Mellanox Junchao-Mellanox commented Nov 14, 2023

Why I did it

For cmis host management mode, the prevous sysfs cannot be used for low power mode setting. This PR reuses existing low power mode implementation in sonic_xcvr package when CMIS host management mode is enabled

Work item tracking
  • Microsoft ADO (number only):

How I did it

Use sonic_xcvr low power mode implementation when CMIS host management mode is enabled.

How to verify it

Manual test for CMIS host management mode
Regression test for old mode and backward compatible test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liat-grozovik
Copy link
Collaborator

@keboliu @prgeor please help to review.

@Junchao-Mellanox Junchao-Mellanox marked this pull request as draft December 4, 2023 07:35
@Junchao-Mellanox Junchao-Mellanox marked this pull request as ready for review December 7, 2023 08:33
@Junchao-Mellanox
Copy link
Collaborator Author

Hi @liat-grozovik , could you please help merge?

@liat-grozovik liat-grozovik merged commit b0bb3d4 into sonic-net:master Dec 11, 2023
12 checks passed
@Junchao-Mellanox Junchao-Mellanox deleted the master_lpm branch December 12, 2023 05:47
@Junchao-Mellanox
Copy link
Collaborator Author

Need cherry-pick to 202311 after #17294

keboliu pushed a commit to keboliu/sonic-buildimage that referenced this pull request Dec 19, 2023
…et#17159)

- Why I did it
For cmis host management mode, the prevous sysfs cannot be used for low power mode setting. This PR reuses existing low power mode implementation in sonic_xcvr package when CMIS host management mode is enabled

- How I did it
Use sonic_xcvr low power mode implementation when CMIS host management mode is enabled.

- How to verify it
Manual test for CMIS host management mode
Regression test for old mode and backward compatible test
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jan 5, 2024
…et#17159)

- Why I did it
For cmis host management mode, the prevous sysfs cannot be used for low power mode setting. This PR reuses existing low power mode implementation in sonic_xcvr package when CMIS host management mode is enabled

- How I did it
Use sonic_xcvr low power mode implementation when CMIS host management mode is enabled.

- How to verify it
Manual test for CMIS host management mode
Regression test for old mode and backward compatible test
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #17693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants