-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nvidia] Update syncd docker to use python version 3 #17735
Merged
yxieca
merged 4 commits into
sonic-net:master
from
liorghub:master_syncd_remove_python2
Jan 30, 2024
Merged
[Nvidia] Update syncd docker to use python version 3 #17735
yxieca
merged 4 commits into
sonic-net:master
from
liorghub:master_syncd_remove_python2
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyrsamotiy
approved these changes
Jan 23, 2024
11 tasks
yxieca
approved these changes
Jan 30, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jan 30, 2024
* Remove python2 from compilation of python-sdk-api * Upgrade Python version in syncd RPC docker image to Python3
Cherry-pick PR to 202311: #17950 |
12 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Remove python2 from compilation of python-sdk-api * Upgrade Python version in syncd RPC docker image to Python3
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Jan 31, 2024
@yxieca can you please cherry pick to 202305 as well? |
@StormLiangMS Can you please cherry pick to 202305? |
this seems not a necessary for 202305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Python 2 is obsolete and no longer supported.
Work item tracking
How I did it
Change several packages installation commands in Nvidia syncd dockerfile to Python3 packages.
Change was done for regular image and for RPC image as well.
How to verify it
I tested several SDK API scripts manually (while all others are tested by SDK verification) and ran regression tests that run on RPC version.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)