Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nvidia] Update syncd docker to use python version 3 #17735

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

liorghub
Copy link
Contributor

Why I did it

Python 2 is obsolete and no longer supported.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Change several packages installation commands in Nvidia syncd dockerfile to Python3 packages.
Change was done for regular image and for RPC image as well.

How to verify it

I tested several SDK API scripts manually (while all others are tested by SDK verification) and ran regression tests that run on RPC version.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202311

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liorghub liorghub requested a review from lguohan as a code owner January 10, 2024 06:53
@yxieca yxieca merged commit 865042e into sonic-net:master Jan 30, 2024
12 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jan 30, 2024
* Remove python2 from compilation of python-sdk-api

* Upgrade Python version in syncd RPC docker image to Python3
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #17950

mssonicbld pushed a commit that referenced this pull request Jan 31, 2024
* Remove python2 from compilation of python-sdk-api

* Upgrade Python version in syncd RPC docker image to Python3
@liorghub
Copy link
Contributor Author

@yxieca can you please cherry pick to 202305 as well?

@liorghub
Copy link
Contributor Author

@StormLiangMS Can you please cherry pick to 202305?

@StormLiangMS
Copy link
Contributor

this seems not a necessary for 202305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants