Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yang-models interface name length validation #20108

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

arfeigin
Copy link
Contributor

@arfeigin arfeigin commented Sep 3, 2024

This PR is accompanied by sonic-net/sonic-swss-common#889 and sonic-net/sonic-utilities#3397

Why I did it

Validate interface name length does not exceed the limitation of IFNAMSIZ to align to kernel restrictions.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Add validation checks in the relevant yang-model definitions for the following interface types:

vxlan
vlan
vrf
loopback
subinterface
portchannel

How to verify it

UT added

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@arfeigin
Copy link
Contributor Author

arfeigin commented Sep 4, 2024

/azpw ms_conflict

2 similar comments
@arfeigin
Copy link
Contributor Author

arfeigin commented Sep 4, 2024

/azpw ms_conflict

@arfeigin
Copy link
Contributor Author

arfeigin commented Sep 8, 2024

/azpw ms_conflict

Modify the valid tunnel name test to use 15 chars tunnel name
Modify the valid tunnel name test to use 15 chars tunnel name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants