Add helper function to validate interface name length #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2024
|
@prsunny Can you help please reviewing this and the attached PRs? |
nazariig
approved these changes
Jul 29, 2024
|
@prsunny , @qiluo-msft , Can you please approve this PR ? |
qiluo-msft
reviewed
Aug 28, 2024
|
|
||
| size_t ifaceNameMaxLen() | ||
| { | ||
| return IFNAMSIZ; |
There was a problem hiding this comment.
@liuh-80 The purpose of this PR is to share a const to multiple applications in C++/python/go. What is the best practice? any sample?
11 tasks
|
Do you still need this PR? if not, you can 'Close' it. |
I think it is good to have this PR in order to export IFNAMSIZ value for sonic-utilities config scripts, not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is accompanied by sonic-net/sonic-buildimage#20108 and sonic-net/sonic-utilities#3397
Add helper function to validate that interface name length does not exceed allowed length configured as IFNAMSIZ. This will be used both by sonic-utilities CLI (config) and by cfgmgr.