Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix agent tests model preferences state #5828

Merged
merged 3 commits into from
Oct 5, 2024
Merged

fix agent tests model preferences state #5828

merged 3 commits into from
Oct 5, 2024

Commits on Oct 5, 2024

  1. remove unused chat/restore agent method 

    This is [not used in JetBrains](https://sourcegraph.com/search?q=repo:sourcegraph/jetbrains+chat/restore&patternType=keyword&sm=0) and was marked for deletion 2 months ago.
    @sqs
    sqs committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    7036136 View commit details
    Browse the repository at this point in the history

  2. fix counter for tapLog 

    Also `console.debug` is not supported everywhere, so just use `console.log`.
    @sqs
    sqs committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    849d286 View commit details
    Browse the repository at this point in the history

  3. fix agent tests model preferences state 

    In the agent tests, the `testing/reset` command was not entirely resetting the state between tests. This meant that 2 tests (explain and smell) that performed explicit `chat/setModel` requests to change the model to Mixtral were running with the chat model used for the previous tests.

The reason is that `testing/reset` just cleared the in-memory `LocalStorageProvider` backing `Map` and did not cause `LocalStorageProvider` to fire a change event, which is necessary for the `ModelsService` to know that the models preferences changed.

Also clean up types.
    @sqs
    sqs committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    a66c741 View commit details
    Browse the repository at this point in the history