Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and refactoring to discord changelog script #33859

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes and refactoring to discord changelog script #33859

wants to merge 2 commits into from
+125 −90

Conversation

irismessage
Copy link
Contributor

Upstreamed from impstation#1023

This rewrites the script used to send new changelog entries to a discord webhook. There was a comment in the script noting that it wasn't robust on very long individual changelog entires. We ran into that on our fork so I fixed it to handle arbitrarily long messages and arbitrarily long change groups. Also tidy it up a bit and use isort and black

@github-actions github-actions bot added size/L Denotes a PR that changes 100-1000 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. and removed size/L Denotes a PR that changes 100-1000 lines. labels Dec 14, 2024
@PJB3005 PJB3005 self-assigned this Dec 14, 2024
@PJB3005 PJB3005 added T: Refactor Type: Refactor of notable amount of codebase and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 14, 2024
@Simyon264 Simyon264 added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Core Tech Area: Underlying core tech for the game and the Github repository. labels Dec 14, 2024
@irismessage
Copy link
Contributor Author

irismessage commented Dec 15, 2024 •
edited
Loading

here it is successfully catching up on our changelog:

image

previously, the large union station changeset broke it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@PJB3005 PJB3005

Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted T: Refactor Type: Refactor of notable amount of codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irismessage @PJB3005 @Simyon264