Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - test(activation): remove parallelism on poet test #6228

Closed
wants to merge 2 commits into from

Conversation

acud
Copy link
Contributor

@acud acud commented Aug 7, 2024

Motivation

Removing t.Parallel to improve test flakes.

Description

Test Plan

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.0%. Comparing base (5ac3af2) to head (631e87b).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6228     +/-   ##
=========================================
- Coverage     82.0%   82.0%   -0.1%     
=========================================
  Files          309     309             
  Lines        34120   34120             
=========================================
- Hits         28003   27991     -12     
- Misses        4337    4347     +10     
- Partials      1780    1782      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acud
Copy link
Contributor Author

acud commented Aug 7, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 7, 2024
## Motivation

Removing `t.Parallel` to improve test flakes.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Aug 7, 2024

Build failed:

@acud
Copy link
Contributor Author

acud commented Aug 7, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 7, 2024
## Motivation

Removing `t.Parallel` to improve test flakes.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Aug 7, 2024

Build failed:

  • ci-status

@acud
Copy link
Contributor Author

acud commented Aug 7, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 7, 2024
## Motivation

Removing `t.Parallel` to improve test flakes.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Aug 7, 2024

Build failed:

@acud
Copy link
Contributor Author

acud commented Aug 7, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 7, 2024
## Motivation

Removing `t.Parallel` to improve test flakes.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Aug 7, 2024

Build failed:

@acud
Copy link
Contributor Author

acud commented Aug 7, 2024

bors merge

@spacemesh-bors
Copy link

spacemesh-bors bot commented Aug 7, 2024

Merge conflict.

@acud
Copy link
Contributor Author

acud commented Aug 8, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 8, 2024
## Motivation

Removing `t.Parallel` to improve test flakes.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Aug 8, 2024

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title test(activation): remove parallelism on poet test [Merged by Bors] - test(activation): remove parallelism on poet test Aug 8, 2024
@spacemesh-bors spacemesh-bors bot closed this Aug 8, 2024
@spacemesh-bors spacemesh-bors bot deleted the no-poet-paralllel branch August 8, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants