Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(disabled) ability to "freeze" subsets by converting to masks #2421

Closed
wants to merge 1 commit into from

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Sep 5, 2023

Description

This pull request is to implement support for "freezing" subsets to masks.

TODO:

  • support in app.get_subsets() and the subset tools plugin (masks should show as an entry, even if the only information provided is that there is a masked subset in the list of sub-subsets).

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 3.7 milestone Sep 5, 2023
@pllim
Copy link
Contributor

pllim commented Sep 5, 2023

I thought we discussed this and decided that this is too resource intensive? You have to read all the image pixels to memory even if your mask is very small (though I don't grok all the stuff you copied from glue there)?

Also see glue-viz/glue#2415 (review)

@kecnry
Copy link
Member Author

kecnry commented Sep 5, 2023

this is not for the same purpose and so would not be done automatically ever, but only when the user intentionally wants to create a mask. Right now, the only obvious use-case for this is in lcviz (spacetelescope/lcviz#45) and therefore support in jdaviz is disabled by default unless configs enable it.

@javerbukh javerbukh mentioned this pull request Sep 15, 2023
9 tasks
@kecnry
Copy link
Member Author

kecnry commented Sep 18, 2023

Superseded by #2462

@kecnry kecnry closed this Sep 18, 2023
@kecnry kecnry deleted the subset-freeze branch February 13, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants