enable subset freezing #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
10 tasks
kecnry
force-pushed
the
subset_freeze
branch
2 times, most recently
from
f935c68 to
cd45c50
Compare
kecnry
added
waiting-on-jdaviz-release
* requires upstream PR
kecnry
force-pushed
the
subset_freeze
branch
from
cd45c50 to
7170cc0
Compare
bmorris3
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables support from
spacetelescope/jdaviz#2421spacetelescope/jdaviz#2462 into lcviz's subset plugin.Screen.Recording.2023-09-05.at.11.31.18.AM.mov
This would require that PR to be merged (along with the necessary fixes for get_subsets and the subset plugin), but should not require it to be released in order to move forward with this PR.This can be merged without jdaviz 3.7 released, but will require testing with jdaviz after that PR is merged (lcviz should work with and without, but this feature will only be shown if you have jdaviz with the upstream PR).